Status

()

enhancement
P2
normal
RESOLVED FIXED
a month ago
13 days ago

People

(Reporter: achronop, Assigned: achronop)

Tracking

(Blocks 1 bug)

66 Branch
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

RemoteDecoderParent needs to inform the child when the shutdown of the decoder has been completed. RemoteDecoderChild needs to resolve a promise on completion.

This can be achieved by either using the MozPromise binding with IPDL in RemoteDecoderParent::RecvShutdown() [1] or by creating a new IPDL message, something like ShutdownComplete, that will be sent to the child when the shutdown of the decoder has finished. Then the method RemoteDecoderChild::Shutdown() [2] can be changed to return a promise and to use the information from the parent to resolve that promise.

[1] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderParent.cpp#137
[2] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderChild.cpp#145

Assignee

Updated

a month ago
Assignee: nobody → achronop
Assignee

Comment 1

a month ago

Create a new IPDL message ShutdownComplete, direction from parent (RDD) to child (content), to inform the child when the decoder shutdown has been completed. The remote decoder child uses that message to resolve the shutdown promise.

Comment 2

a month ago
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b326aa4930c
Make the remote decoder shutdown async. r=mjf
Assignee

Comment 4

a month ago

Thank you for backing out, I am looking at it.

Flags: needinfo?(achronop)
Assignee

Comment 11

23 days ago

Could you have a look at the failures on comment 9 and tell me what you think. All of them are unrelated to RDD, the decoder does not run at all on the failed runs. I am lost at the moment, if you have any idea or something for me to try, will help. Thanks!

Flags: needinfo?(mfroman)
Blocks: RDD
Flags: needinfo?(mfroman)

Comment 13

14 days ago
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d0548740e1e
Make the remote decoder shutdown async. r=mjf

Comment 14

14 days ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee

Updated

13 days ago
Blocks: 1550737
You need to log in before you can comment on or make changes to this bug.