1545416 - Make RDD shutdown async.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

RemoteDecoderParent needs to inform the child when the shutdown of the decoder has been completed. RemoteDecoderChild needs to resolve a promise on completion.

This can be achieved by either using the MozPromise binding with IPDL in RemoteDecoderParent::RecvShutdown() [1] or by creating a new IPDL message, something like ShutdownComplete, that will be sent to the child when the shutdown of the decoder has finished. Then the method RemoteDecoderChild::Shutdown() [2] can be changed to return a promise and to use the information from the parent to resolve that promise.

[1] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderParent.cpp#137
[2] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderChild.cpp#145

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1545416 - Make the remote decoder shutdown async. r?mjf

Create a new IPDL message ShutdownComplete, direction from parent (RDD) to child (content), to inform the child when the decoder shutdown has been completed. The remote decoder child uses that message to resolve the shutdown promise.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b326aa4930c
Make the remote decoder shutdown async. r=mjf

Comment 3

[Razvan Maries]

Backed out for causing multiple perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=7b326aa4930cad966e0a01d2d3d3d585d35002e2&selectedJob=242117002

Failure logs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242117012&repo=autoland&lineNumber=13840
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242116986&repo=autoland&lineNumber=1308

Backout: https://hg.mozilla.org/integration/autoland/rev/0ce3633f8b80b9bcb69165f6ec4dc97f19fa8f0a

Comment 4

[Alex Chronopoulos [:achronop]]

Thank you for backing out, I am looking at it.

Comment 5

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=415bbb9a244604a1c571f3b94e19a8695e8d2ce2

Comment 6

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b91fccd09b6f018cb7adcdafb85ee6869030478

Comment 7

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec8fdccea7a30e73496febfba30524895799d620

Comment 8

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f83cb52c903015883cee1accb05357f0033b6d7

Comment 9

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb4db0c124c76f9d0abe167240839b5af299a4c9

Comment 10

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a5e1f04649406dc7cfe535f33aa28f6858b8def

Comment 11

[Alex Chronopoulos [:achronop]]

Could you have a look at the failures on comment 9 and tell me what you think. All of them are unrelated to RDD, the decoder does not run at all on the failed runs. I am lost at the moment, if you have any idea or something for me to try, will help. Thanks!

Comment 12

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e11afd7e5212b67533c10f9c9254991b1a65e70

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d0548740e1e
Make the remote decoder shutdown async. r=mjf

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0d0548740e1e