Closed Bug 1545416 Opened 2 years ago Closed 2 years ago

Make RDD shutdown async.

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

66 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: achronop, Assigned: achronop)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

RemoteDecoderParent needs to inform the child when the shutdown of the decoder has been completed. RemoteDecoderChild needs to resolve a promise on completion.

This can be achieved by either using the MozPromise binding with IPDL in RemoteDecoderParent::RecvShutdown() [1] or by creating a new IPDL message, something like ShutdownComplete, that will be sent to the child when the shutdown of the decoder has finished. Then the method RemoteDecoderChild::Shutdown() [2] can be changed to return a promise and to use the information from the parent to resolve that promise.

[1] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderParent.cpp#137
[2] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderChild.cpp#145

Assignee: nobody → achronop

Create a new IPDL message ShutdownComplete, direction from parent (RDD) to child (content), to inform the child when the decoder shutdown has been completed. The remote decoder child uses that message to resolve the shutdown promise.

Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b326aa4930c
Make the remote decoder shutdown async. r=mjf

Thank you for backing out, I am looking at it.

Flags: needinfo?(achronop)

Could you have a look at the failures on comment 9 and tell me what you think. All of them are unrelated to RDD, the decoder does not run at all on the failed runs. I am lost at the moment, if you have any idea or something for me to try, will help. Thanks!

Flags: needinfo?(mfroman)
Blocks: RDD
Flags: needinfo?(mfroman)
Pushed by achronopoulos@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d0548740e1e
Make the remote decoder shutdown async. r=mjf
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Blocks: 1550737
You need to log in before you can comment on or make changes to this bug.