Make RDD shutdown async.
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: achronop, Assigned: achronop)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
RemoteDecoderParent
needs to inform the child when the shutdown of the decoder has been completed. RemoteDecoderChild
needs to resolve a promise on completion.
This can be achieved by either using the MozPromise binding with IPDL in RemoteDecoderParent::RecvShutdown()
[1] or by creating a new IPDL message, something like ShutdownComplete, that will be sent to the child when the shutdown of the decoder has finished. Then the method RemoteDecoderChild::Shutdown()
[2] can be changed to return a promise and to use the information from the parent to resolve that promise.
[1] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderParent.cpp#137
[2] https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/dom/media/ipc/RemoteDecoderChild.cpp#145
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Create a new IPDL message ShutdownComplete
, direction from parent (RDD) to child (content), to inform the child when the decoder shutdown has been completed. The remote decoder child uses that message to resolve the shutdown promise.
Comment 3•6 years ago
|
||
Backed out for causing multiple perma failures.
Failure logs: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242117012&repo=autoland&lineNumber=13840
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242116986&repo=autoland&lineNumber=1308
Backout: https://hg.mozilla.org/integration/autoland/rev/0ce3633f8b80b9bcb69165f6ec4dc97f19fa8f0a
Assignee | ||
Comment 4•6 years ago
|
||
Thank you for backing out, I am looking at it.
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Could you have a look at the failures on comment 9 and tell me what you think. All of them are unrelated to RDD, the decoder does not run at all on the failed runs. I am lost at the moment, if you have any idea or something for me to try, will help. Thanks!
Assignee | ||
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
bugherder |
Description
•