1545473 - WebGL conformance test conformance/attribs/gl-vertex-attrib-unconsumed-out-of-bounds.htmls tab crash MacOS

Status: VERIFIED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Description

[Bogdan Maris, Desktop QA]

Affected versions

• Firefox 66.0.3
• Firefox 67.0b11
• Latest Nightly 68.0a1

Affected platforms

• macOS 10.13

Unaffected platforms

• Windows 10
• Ubuntu 18.04

Steps to reproduce

1. Start Firefox
2. Visit the following url: https://www.khronos.org/registry/webgl/sdk/tests/conformance/attribs/gl-vertex-attrib-unconsumed-out-of-bounds.html?webglVersion=1&quiet=0&quick=1

Expected result

• Test passes.

Actual result

• The tab crashes.

Regression range

• First bad: 6ebc251bd288c268b020815025b05854ccde5c08 (2017-08-16)
• Last good: d25db0546c92afa72d61685c9310104ef28235bd (2017-08-15)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d25db0546c92afa72d61685c9310104ef28235bd&tochange=6ebc251bd288c268b020815025b05854ccde5c08
• Potential regressor: Not sure what is the regressor here.

Additional notes

• For 67 Beta and 66 RC I get the following crash signature:
  [@mozilla::gl::GLContext::GetError ]
  https://crash-stats.mozilla.org/report/index/25d6604d-76e4-43cf-9c15-2abda0190418
• For 68 Nightly I get a different crash signature:
  [@XUL@0x19dc6c0 | XUL@0x2dc902d | XUL@0x2851e7f | XUL@0x2d16381 | XUL@0x539e16f | XUL@0x53968bc | XUL@0x5388a1f | XUL@0x539f987 | XUL@0x539fbb3 | XUL@0x5463967 | XUL@0x3a997e1 | XUL@0x3a98e7b | XUL@0x3a969d5 | XUL@0x3a88e38 | XUL@0x3a86ed8 | XUL@0x18e0c8... ]
  https://crash-stats.mozilla.org/report/index/79b4701e-821d-4986-9e5e-b48b70190418
• The crash happens on both 1.0.4 and 2.0.1

Comment 1

[Pascal Chevrel:pascalc]

Too low volume for an uplift.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1545473 - Use FakeVertexAttrib0 for no-attrib programs on macOS.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dc839c3e6b3
Use FakeVertexAttrib0 for no-attrib programs on macOS. r=lsalzman

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2dc839c3e6b3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

I'm assuming this can ride the trains given where we are in the cycle, but feel free to nominate for Beta approval if you feel strongly otherwise.

Comment 6

[Kelsey Gilbert [:jgilbert]]

I think we're good with letting it ride. The crash volume isn't high, and this isn't a regression.

Comment 7

[Kelsey Gilbert [:jgilbert]]

Ok, so technically it's a regression, but it's not a new one. (it's on Release right now)

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1545473 - Re-enable skipped tests.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fbb1aab6c33
Re-enable skipped tests.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2fbb1aab6c33

Comment 11

[Daniel Bodea [:danibodea]]

I have reproduced the tab crash on Firefox Release v68.0.2 and verified the fix in Firefox Release v69.0, Beta v70.0b3 and Nightly v71.0a1 on Mac OS 10.13.6.