Closed Bug 1545521 Opened 4 months ago Closed 4 months ago

Switch the Addon Manager startup cache to using lz4_decompress_safe

Categories

(Toolkit :: Add-ons Manager, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: RyanVM, Assigned: kmag)

References

Details

Attachments

(1 file)

Currently, the Addon Manager startup cache uses the lz4_decompress_fast function. However, it's due to be deprecated soon in favor of the lz4_decompress_safe version (which upstream claims is faster these days anyway).

Assignee: nobody → kmaglione+bmo

In previous versions of the LZ4 library, lz4_decompress_fast, which does not
take an input buffer size, was supposed to be faster than lz4_decompress_safe,
which does. In newer versions, however, the reverse is supposed to be true,
and lz4_decompress_fast is therefore deprecated.

This patch updates our code to use the now-preferred "safe" version of the
API.

https://hg.mozilla.org/integration/mozilla-inbound/rev/41b4775f70f99f1cb4f4dd3e03a189a83faad578
Bug 1545521: Use lz4_decompress_safe to decode add-on manager startup cache blobs. r=aswan
Priority: -- → P1
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.