Closed Bug 1545552 Opened 5 years ago Closed 5 years ago

browser_telemetry.js appears to not run

Categories

(Firefox :: Settings UI, task)

Product:
Firefox
Component:
Settings UI
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(1 file)

Bug 1545552 - fix manifest to allow browser_telemetry.js to run. r=jaws
47 bytes, text/x-phabricator-request
Details | Review

https://searchfox.org/mozilla-central/source/browser/components/preferences/in-content/tests/browser.ini#96

[browser_telemetry.js]

Skip this test on Android as FHR and Telemetry are separate systems there.

skip-if = !healthreport || !telemetry || (os == 'linux' && debug) || (os == 'android')

we don't have healthreport anymore, so this test wouldn't run based on the manifest conditions.

:jaws, should we remove the !healthreport?

Flags: needinfo?(jaws)

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task

Yeah, we should remove the !healthreport.

Flags: needinfo?(jaws)

browser_telemetry.js has a condition that requires healthreport to be active. This will never be the case. Removing that gives us a chance to run the test.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38e8c5c2222f
fix manifest to allow browser_telemetry.js to run. r=jaws

https://hg.mozilla.org/mozilla-central/rev/38e8c5c2222f

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → jmaher
Blocks: 1775366
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: