Closed
Bug 1545567
Opened 5 years ago
Closed 5 years ago
Passing a non-buffered input stream to ImageOps::CreateImageBuffer crashes.
Categories
(Core :: Graphics: ImageLib, defect, P3)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla68
People
(Reporter: mossop, Assigned: aosmond)
References
Details
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/image/ImageOps.cpp#106
As far as I can tell if the inputStream is not buffered we wrap it in a new buffered stream (dropping ownership of inputStream in the process), then do nothing with the new stream and later try to use inputStream which is now null.
|
||
Comment 1•5 years ago
|
||
Type: defect → task
|
||
Updated•5 years ago
|
Type: task → defect
|
||
Updated•5 years ago
|
Component: DOM: Core & HTML → ImageLib
|
Assignee | |
Comment 2•5 years ago
|
||
Nice catch. Since there are no crash reports for this, it suggests the streams we get are always buffered, so no need to uplift.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
status-firefox67:
--- → wontfix
status-firefox68:
--- → affected
Priority: -- → P3
|
|
Assignee | |
Comment 3•5 years ago
|
||
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/497afde99626 Ensure ImageOps decode methods can handle unbuffered input streams properly. r=baku
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•