Closed Bug 1545590 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16305 - override `align-items` in flex-vertical-align-effect.html

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16305 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16305
Details from upstream follow.

Daniel Holbert <dholbert@cs.stanford.edu> wrote:

override align-items in flex-vertical-align-effect.html

This fixes issue #16304 by removing the (default) influence of
align-items:stretch on the radio button flex-item, which influences its
sizing/rendering regardless of the value of the vertical-align property
(which is what the testcase is really trying to test). So, let's take that
stretch behavior out of the equation entirely.

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75471ece631c
[wpt PR 16305] - override `align-items` in flex-vertical-align-effect.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/75471ece631c

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.