Closed
Bug 1545595
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 16334 - [tools] Document unintuitive branch
Categories
(Testing :: web-platform-tests, defect, P4)
Testing
web-platform-tests
Tracking
(firefox69 fixed)
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 16334 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/16334
Details from upstream follow.
Mike Pennisi <mike@mikepennisi.com> wrote:
[tools] Document unintuitive branch
Although this pattern is endorsed by the Mypy type checker, it appears
to include an unreachable statement. Contributors lacking familiarity
with Mypy may assume it is spurious debugging logic. Add a comment to
document the special feature provided by the type checker.
@gsnedders At some point, we have to take familiarity with the tooling for
granted, but this feature seems particularly likely to trip up the casual
observer (e.g. me, 10 minutes ago).
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Comment 1•5 years ago
|
||
PR 16334 applied with additional changes from upstream: f17757efc9316c9b0313c7686ee194c871caeb02
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcf0fceaf45114a2dc9370f40a1c082281bac7f5
Assignee | ||
Comment 3•5 years ago
|
||
The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/19f5fdf3d5c9 [wpt PR 16334] - [tools] Document unintuitive branch, a=testonly
Comment 5•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•