[about:addons] Use <slot></slot>, not <slot/> and a few other smaller fixes

RESOLVED FIXED in Firefox 68

Status

()

task
RESOLVED FIXED
a month ago
26 days ago

People

(Reporter: robwu, Assigned: robwu)

Tracking

63 Branch
mozilla68
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a month ago

The end tag of <slot> tags is mandatory, but aboutaddons.html omits them. It uses <slot />, but since it is not a XHTML document, /> doesn't count as a closing tag.

The current code results in the expected DOM tree, because the <slot/> is immediately followed by another closing tag (which causes the HTML parser to insert the missing closing </slot> tag). However if we were to put some other content after it, then the text would be part of the default slot instead of being rendered after the slot. So let's fix it to avoid surprises in the future.

All /> in the file should be replaced with >. And while we are at, let's also remove the unnecessary type attributes from the script and stylesheet elements, and fix the alphabetical sorting order of the tests at https://searchfox.org/mozilla-central/rev/d302c3058330a57f238be4062fddea629311ce66/toolkit/mozapps/extensions/test/browser/browser.ini#119-120

(Assignee)

Comment 1

a month ago

This patch has no functional changes; It adds missing </slot> tags and
removes some unnecessary type attributes and />.

And it also moves some entries in browser.ini to ensure that the tests
are listed in alphabetical order.

Comment 2

28 days ago
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/e2cc8fc0986e
Fix HTML tags in aboutaddons.html r=mstriemer

Comment 3

27 days ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
(Assignee)

Updated

27 days ago
Flags: qe-verify-

Comment 4

26 days ago

Rob pointed out to me that this patch has been landed without a peer r+ by mistake, but (for the record) the patch looks good to me and it has been reviewed by mstriemer (to whom this review has been delegated).

You need to log in before you can comment on or make changes to this bug.