Open Bug 1545642 Opened 6 years ago Updated 3 years ago

Overview Network Timeline

Categories

(DevTools :: Netmonitor, enhancement, P3)

Product:
DevTools
Component:
Netmonitor
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: Harald, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: parity-chrome)

Inspired by Chrome.

Provides several interactions that we currently lack:

  • More room for a readable waterfall chart
  • Zoom in on specific part of the recording
Keywords: meta

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:Honza, maybe it's time to close this bug?

Flags: needinfo?(odvarko)

Harald, what about breaking this down to some small actionable bug reports so, somebody can start contributing to it?
Honza

Flags: needinfo?(odvarko) → needinfo?(hkirschner)

This seems like a rather advanced project with a lot of UI decisions. But maybe phases could be the following:

  1. Optional horizontal timeline that aggregates the waterfall over time
  2. Navigation in that timeline to limit table output to requests in the selected range

Is there anything before or in-between that can be a sub-milestone?

Flags: needinfo?(hkirschner)

Greg, do you have some preliminary info about how could we reuse Profiler's Network timeline in DevTools Network panel?
What's e.g. the complexity/risks/limitation?

Honza

Flags: needinfo?(gtatum)

The goal of reuse is a good one. We probably would need to invest in the current profiler network track to advance the interface as it's so far in a very early stage.

Hmm... I would recommend copy/pasting the code and modifying if you want to adapt it to the network panel. Our react components have lots of types in them which will need to be removed, and I'm assuming they are operating on different data structures, as we're using Gecko Profiler markers. Our UI is not very polished at the moment. I'd not recommend sharing code here, as it would be difficult to upstream changes between the profiler's repo and m-c.

The biggest things our implementation could bring is the virtualization machinery, which works pretty well, and is very performant. I will say it's original code to the project, and has "just worked" for the most part, so there's not as many tests or or documentation for it. Moving all of this component over to m-c would be a bit of a hack job I think, but it could save some time on the implementation. I just don't see our implementation being very generic. I'm happy to chat more synchronously if you want to explore this route.

Flags: needinfo?(gtatum)

Thanks Greg! Can you please point us to the place where the (a) Timeline and (b) virtualization code is?

Flags: needinfo?(gtatum)

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:Honza, maybe it's time to close this bug?

Flags: needinfo?(odvarko)

Removing the meta flag.
The original idea is still valid.

Honza

Blocks: netmonitor-timings-sidepanel
Flags: needinfo?(odvarko)
Keywords: meta
Priority: P2 → P3
Summary: [meta] Overview Network Timeline → Overview Network Timeline
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.