Closed Bug 1545644 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16303 - Do not resume a suspended BaseAudioContext when AudioWorklet starts

Categories

(Core :: Web Audio, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16303 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16303
Details from upstream follow.

Hongchan Choi <hongchan@chromium.org> wrote:

Do not resume a suspended BaseAudioContext when AudioWorklet starts

When AudioWorklet.addModule() activates the worklet thread, it
re-starts the destination handler even when the context is suspended.
This CL fixes the bug by restarting destination only when the context
is in the "running" state.

Bug: 950997
Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html
Change-Id: I0b44e3fca23bd069fac21f709fc665e8eacc4dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560140
Commit-Queue: Hongchan Choi \<hongchan@chromium.org>
Reviewed-by: Raymond Toy \<rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649303}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Web Audio
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bfc2b0800626
[wpt PR 16303] - Do not resume a suspended BaseAudioContext when AudioWorklet starts, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.