Try to remove ServoStyleSet::ReplaceSheets
Categories
(Core :: CSS Parsing and Computation, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 files)
It's only use by editor to manually remove the contenteditable stylesheet and such, and by some code which doesn't seem in use anymore (the pref observer for general.skins.selectedSkin).
|
Assignee | |
Comment 1•5 years ago
|
||
The editing code should just use RemoveStyleSheet.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
We assume in a bunch of other places that user agent stylesheets don't really
change dynamically. It's not clear to me what this code is trying to accomplish
or how is it supposed to work in a multi-process world, but I've left the author
stylesheets code for now...
Also, I'm pretty sure the styleset doesn't handle null sheets, so add a
null-check to the author stylesheets.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Replacing the whole set of user-agent stylesheets seems a bit overkill.
Depends on D28211
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D28212
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/24ad41213ce4 Don't sync-reload chrome:// user-agent stylesheets from nsChromeRegistry. r=bzbarsky https://hg.mozilla.org/integration/autoland/rev/9d3956ea78a8 Track editor stylesheets better. r=masayuki https://hg.mozilla.org/integration/autoland/rev/c08ca0ff0c98 Remove a dead Loader::LoadSheet function. r=mats
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/24ad41213ce4
https://hg.mozilla.org/mozilla-central/rev/9d3956ea78a8
https://hg.mozilla.org/mozilla-central/rev/c08ca0ff0c98
Description
•