Closed Bug 1545699 Opened 7 months ago Closed 7 months ago

Try to remove ServoStyleSet::ReplaceSheets

Categories

(Core :: CSS Parsing and Computation, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files)

It's only use by editor to manually remove the contenteditable stylesheet and such, and by some code which doesn't seem in use anymore (the pref observer for general.skins.selectedSkin).

The editing code should just use RemoveStyleSheet.

Flags: needinfo?(emilio)
Flags: needinfo?(emilio)

We assume in a bunch of other places that user agent stylesheets don't really
change dynamically. It's not clear to me what this code is trying to accomplish
or how is it supposed to work in a multi-process world, but I've left the author
stylesheets code for now...

Also, I'm pretty sure the styleset doesn't handle null sheets, so add a
null-check to the author stylesheets.

Replacing the whole set of user-agent stylesheets seems a bit overkill.

Depends on D28211

Blocks: 1546329
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/24ad41213ce4
Don't sync-reload chrome:// user-agent stylesheets from nsChromeRegistry. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/9d3956ea78a8
Track editor stylesheets better. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/c08ca0ff0c98
Remove a dead Loader::LoadSheet function. r=mats
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.