1545727 - The viewer for JSON responses is completely inaccessible

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[Dickson Tan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. Visit any API endpoint that returns JSON, such as the root GitHub endpoint
2. Attempt to navigate through the JSON tree with the NVDA screen reader

Actual results:

The contents of the tree view cannot be read with NVDA, except through advanced object navigation techniques. Using the arrow keys to navigate through the tree doesn't work. First letter navigation also doesn't work.

Expected results:

The contents of the tree are accessible, and is keyboard navigatable. Up/down arrows moves you through the tree's contents, and left and right arrows expand / collapse nodes. First letter navigation moves you to the next node, who's key corresponds to the letter just pressed.

Comment 1

[Dickson Tan]

Attachment: Bug 1545727 - make the JSON tree viewer more accessible. r=honza!

Make the JSON tree view more accessible.

1. Automatically set focus to the first node on initial focus. Previously, the only way to interact with the tree view through the keyboard was to click on a node so that subsequent key presses would register.
2. Fix inaccurate aria-level and aria-expanded attributes causing confusing announcements for screen reader users.
3. Previously, pressing left arrow the first time on a leaf child node would not move focus to its parent, but subsequent tries would work. This has been fixed.
4. Implement first-letter navigation for quick movement via keyboard.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a52a8f4ab189
make the JSON tree viewer more accessible. r=Honza

Comment 3

[Andreea Pavel [:apavel]]

Backed out for failing test_tree-view_01.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=290393203&resultStatus=testfailed%2Cbusted%2Cexception&revision=a52a8f4ab189543c913bc43fa2a2f33c86e20a5b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290393203&repo=autoland&lineNumber=2143

Backout: https://hg.mozilla.org/integration/autoland/rev/aadc3d0511033a23b734d593c93a914d91f6dc21

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41f8b0b21560
make the JSON tree viewer more accessible. r=Honza

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/41f8b0b21560