1545743 - On "Secure Connection Failed" screen "Learn more ..." broken

Status: VERIFIED FIXED

(Firefox :: Security, defect, P1)

Description

[Albert Scheiner [:alberts]]

Ran into "Secure Connection Failed" while trying to load https://www.azlyrics.com/ - I assume server misconfigured, with Safari and Opera I get errors as well.

Clicking on the "Learn more…" button doesn't do anything and it shows me the courser: text instead of the cursor: pointer. Here the code from the link:

<a xmlns="http://www.w3.org/1999/xhtml"
   id="learnMoreLink" target="new"
   data-telemetry-id="learn_more_link">Learn more…</a>

Comment 1

[Johann Hofmann [:johannh]]

Ah, so we're missing to set the link on that element. Unfortunately we would need the error type of that website to try and reproduce, but the website is working again. You don't happen to know why the secure connection failed?

Comment 2

[Albert Scheiner [:alberts]]

Sorry Johann, I don't and I wasn't aware that this piece of info was required for a fix of that error page. Will keep it in mind for next time and try to update this ticket if I stumble upon the error and link again.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:wleung, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Johann Hofmann [:johannh]]

Still looking into this. Flod had some STR, I believe.

Thanks!

Comment 5

[Francesco Lodolo [:flod]]

I just went to https://badssl.com/ and selected expired
https://expired.badssl.com/

Click on the link returns

TypeError: doc.body.getAttribute(...) is null
NetErrorChild.jsm:806:30

https://searchfox.org/mozilla-central/source/browser/actors/NetErrorChild.jsm#806

Touched in bug 1484255.

I'm seeing this on Italian build of nightly (68.0a1 (2019-05-08) (64 bit))

Comment 6

[Francesco Lodolo [:flod]]

Adding some more info from IRC conversation with kwan (thanks!): the error page I see is completely different from en-US (no yellow border).

I also see this error in console when it loads

date value is not finite in DateTimeFormat.format() NetErrorChild.jsm:280
    dateTimeFormatFormatToBind self-hosted:2628
    dateTimeFormatFormatToBind self-hosted:1003
    _setTechDetails resource:///actors/NetErrorChild.jsm:280
    onCertErrorDetails resource:///actors/NetErrorChild.jsm:359
    receiveMessage resource:///actors/NetErrorChild.jsm:646
    receiveMessage resource://gre/modules/ActorManagerChild.jsm:165

which leads to bug 1530335. So, what I'm seeing is a different regression (same symptoms).

Comment 7

[Johann Hofmann [:johannh]]

I'm not sure when this actually regressed but I know how to fix it.

Comment 8

[Johann Hofmann [:johannh]]

Can't reproduce on Beta.

Comment 9

[Johann Hofmann [:johannh]]

Attachment: Bug 1545743 - Don't use validity.not{After,Before}LocalTime for parsing date information in NetErrorChild.jsm. r=prathiksha

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8d305fa503b
Don't use validity.not{After,Before}LocalTime for parsing date information in NetErrorChild.jsm. r=prathiksha

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f8d305fa503b

Comment 13

[[e-mail] (:bhearsum)]

This is fixed for me in the latest Nightly - thanks!

Comment 14

[Johann Hofmann [:johannh]]

Thanks!