Closed Bug 1545748 Opened 5 years ago Closed 5 years ago

[meta] Disable Windows Snap for windows that have their aspect ratio locked

Categories

(Core :: Widget: Win32, defect, P3)

Product:
Core
Component:
Widget: Win32
Version:
68 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox68 --- disabled
firefox69 --- disabled
firefox70 --- disabled
firefox71 --- verified

People

(Reporter: george.craciun, Unassigned)

References

Details

(Keywords: meta)

STR:

  1. Ensure media.videocontrols.picture-in-picture.enabled is set to true
  2. Visit https://youtube.com and play a video
  3. Right-click on the video, and choose Picture in Picture
  4. Drag the PiP window to the right of the screen until the border is displayed on half of the screen and release the mouse

ER:

The Picture-in-Picture window should not display white borders above and beyond the video.

AR:

The Picture-in-Picture window is displayed on half of the screen with big white borders above and below the video.

Component: Video/Audio Controls → Widget: Win32
Priority: -- → P3
Product: Toolkit → Core
Summary: The Picture-in-Picture window displays white borders above and below the video when it's resized on half of the screen → Disable Windows Snap for windows that have their aspect ratio locked
Priority: P3 → --

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Priority: -- → P3

We have another option, which is to allow the player window to "snap" like this, despite being aspect ratio locked (this will also help users with tiled window managers), but to reduce the "broken" appearance of the snapped window by making the background colour less jarring.

One idea is to use the same background texture that we use when viewing image files.

This will effectively be fixed by the patches in bug 1543027 and bug 1581942

Depends on: 1581942, 1543027

The dependencies are closed now.

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: affected → disabled
status-firefox69: --- → disabled
status-firefox70: --- → disabled
status-firefox71: --- → fixed
Keywords: meta
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Summary: Disable Windows Snap for windows that have their aspect ratio locked → [meta] Disable Windows Snap for windows that have their aspect ratio locked

Build ID 20191027212548
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Verified as fixed on the latest Nightly build on Windows 7.

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified
You need to log in before you can comment on or make changes to this bug.