Closed Bug 1545768 Opened 8 months ago Closed 7 months ago

Fix the bounds of text items for webrender

Categories

(Core :: Graphics: WebRender, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: Gankra, Assigned: Gankra)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attempted fix in Bug 1529992, partially backed out in Bug 1544895.

The issue is that asking webrender to do the shadow inflation seemingly led to it messing up snapping when the effective blur wasn't an integer (shadow.blur * devicePixelRatio / 2). As a result the text itself became blurry.

Hopefully this bug is just a matter of waiting for Bug 1540200 to be fixed and then reverting https://hg.mozilla.org/mozilla-central/rev/580a7e38c604

Assignee: nobody → a.beingessner
Blocks: wr-68
Depends on: 1540200
Priority: -- → P2

ni? aosmond to see if reverting the above patch is fine on their branch

Flags: needinfo?(aosmond)

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3eeb6567afaeb1a0f0af33cfc52e6a71bff8811

It doesn't look blurry to me with my local build, but I might not have the right frame of reference :). Patches are up for review on my bug, so you can pull it down from phabricator if need be.

Flags: needinfo?(aosmond)

This just reverts commit 580a7e38c60491123f3e7bba82904008ab0262d1.

Pushed by abeingessner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61f88342d747
Re-enable good text bounds for webrender. r=kats
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.