Fix the bounds of text items for webrender
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: Gankra, Assigned: Gankra)
References
Details
Attachments
(1 file)
Attempted fix in Bug 1529992, partially backed out in Bug 1544895.
The issue is that asking webrender to do the shadow inflation seemingly led to it messing up snapping when the effective blur wasn't an integer (shadow.blur * devicePixelRatio / 2). As a result the text itself became blurry.
Hopefully this bug is just a matter of waiting for Bug 1540200 to be fixed and then reverting https://hg.mozilla.org/mozilla-central/rev/580a7e38c604
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
ni? aosmond to see if reverting the above patch is fine on their branch
|
||
Comment 2•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3eeb6567afaeb1a0f0af33cfc52e6a71bff8811
It doesn't look blurry to me with my local build, but I might not have the right frame of reference :). Patches are up for review on my bug, so you can pull it down from phabricator if need be.
|
|
Assignee | |
Comment 3•5 years ago
|
||
This just reverts commit 580a7e38c60491123f3e7bba82904008ab0262d1.
|
|
Assignee | |
Comment 4•5 years ago
|
||
Pushed by abeingessner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/61f88342d747 Re-enable good text bounds for webrender. r=kats
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•