154579 - filepicker dialog crashes at TestGtkEmbed

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Michael Shtein]

The bug is reproducable only at TestGtkEmbed (it works fine at 
Mozilla itself).

To reproduce the crash please make the following:
1. Click at browser on some .pdf file
2. You will get some dialog with options Open using application/
Save this file to disk ...
3. Check "Open using an application" option.
4. Click on Choose button.
5. You will get filepicker that is not functioning,
6. Checking "Show hidden files and directories" button will
cause to crash.

Comment 1

[Boris 'pi' Piwinger]

*** Bug 154578 has been marked as a duplicate of this bug. ***

Comment 2

[Adam Lock]

Probably due to the implementation or lack thereof of a
nsIHelperAppLauncherDialog service in the GTK widget.

-> Chris

Comment 3

[Michael Shtein]

Attachment: the stack.

The stack of TestGtkEmbed's crash

Comment 4

[greer]

Note: The stack is the same as bug 149141, which I marked as fixed because (as
the reporter points out) it works in Mozilla.

Comment 5

[Michael Shtein]

The problem is in file xpfe/components/filepicker/res/content/filepicker.js,
since method window.setCursor() is not defined. Adding check if("setCursor" in
window) solves the problem. That seems to be due to the fact that the window
is not chrome one. What I don't understand is why at Mozilla the window is
chrome and at TestGtkEmbed it isn't.

Comment 6

[Michael Shtein]

Attachment: the patch of the file xpfe/components/filepicker/res/content/filepicker.js

Comment 7

[Boris Zbarsky [:bzbarsky]]

The JS thing should not be needed; the embedding stuff should not be crashing
because of a setCursor call from JS!

Comment 8

[Michael Shtein]

Embedded code did not crash at the setCursor call from JS.
The problem is that since Embedding windows don't support 
setCursor method -> JS stopped its work at the setCursor 
line -> it didn't initialize needed FilePicker properties,
that it should have done later -> and this uninitializing 
caused the crash.

Comment 9

[Robert Kaiser]

AFAIK, GTK embedding in that way has been discontinued, and future embedding efforts will likely go different ways, so this bug is probably not relevant any more.
That said, there's no info here on any recent software versions and code responsible for that probably has changed a lot. If this is still relevant, please reopen with current info and a crash signature.