Closed
Bug 1545796
Opened 6 years ago
Closed 6 years ago
'addBreakpoint' may set incorrect emptyLines when run before source text has loaded
Categories
(DevTools :: Debugger, defect, P1)
DevTools
Debugger
Tracking
(firefox68 fixed)
RESOLVED
FIXED
Firefox 68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We used to wait for text to load before adding breakpoints, but I'm not certain we do that properly now that we use addBreakpoint in more places.
We should just rewrite emptyLines so it does not rely on the source text being present at the time it loads.
|
Assignee | |
Comment 1•6 years ago
|
||
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ab859fec944
Invert emptyLines to breakableLines so we no longer need to rely on source text. r=jlast
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in
before you can comment on or make changes to this bug.
Description
•