1545831 - Use generateQI in a few more places

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

A search for "QueryInterface :" finds a few places that still manually implement QI. I don't know why kmag's mass conversion from before missed these.

Comment 1

[Kris Maglione [:kmag]]

(In reply to Andrew McCreight [:mccr8] from comment #0)

I don't know why kmag's mass conversion from before missed these.

I'm not sure either. I know there were a few plain mochitests that used SpecialPowers to mock components that I gave up trying to make generateQI work with. The amount of security wrapper craziness involved in such things is just absurd...

I think I probably skipped the remaining test-only uses of manual QI functions because it wasn't obvious which ones would break, and fixing them didn't seem super critical.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1545831 - Use ChromeUtils.generateQI in a few more places.

Comment 3

[Andrew McCreight [:mccr8]]

This also finds some more, but at 140 or so results, is probably past the point where it is reasonable to write a patch by hand. https://searchfox.org/mozilla-central/search?q=QueryInterface%3A+f&path=

But yeah, it does looks like either devtools or tests stuff, so fixing it won't have a direct impact.

Comment 4

[Kris Maglione [:kmag]]

Also https://searchfox.org/mozilla-central/search?q=%5E%5Cs*QueryInterface%5C((aI%7Ci)&case=true&regexp=true&path=

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0719cb95e437
Use ChromeUtils.generateQI in a few more places. r=kmag

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0719cb95e437