1545907 - remove grid usage from comm/mailnews/base/prefs/content/am-identity-edit.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1545907_remove-grid-am-identity-edit.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9059634 [details] [diff] [review]
Bug-1545907_remove-grid-am-identity-edit.patch

Review of attachment 9059634 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/am-identity-edit.xul
@@ +70,5 @@
> +          <hbox>
> +            <vbox>
> +              <hbox flex="1" align="center">
> +                <label value="&name.label;" control="identity.fullName"
> +                       accesskey="&name.accesskey;"/>

these are now much less wider than they used to be

I see on trunk this whole thing is actually larger than it should be so the Manage identities button is pushed out of view and needs to be scrolled into view to find/click. (Because the text boxes are over wide.) Maybe we should fix that first.

@@ +126,5 @@
>  
> +          <hbox align="center">
> +            <checkbox id="identity.attachVCard" label="&attachVCard.label;"
> +                      flex="1" accesskey="&attachVCard.accesskey;"/>
> +            <button class="push" name="editVCard" label="&editVCard.label;"

please remove the name while you're here - it doesn't do anything

@@ +128,5 @@
> +            <checkbox id="identity.attachVCard" label="&attachVCard.label;"
> +                      flex="1" accesskey="&attachVCard.accesskey;"/>
> +            <button class="push" name="editVCard" label="&editVCard.label;"
> +                    accesskey="&editVCard.accesskey;" oncommand="editVCard()"/>
> +            <label hidden="true" id="identity.escapedVCard"/>

and move id first

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1545907_remove-grid-am-identity-edit.patch

Comment 4

[Khushil Mistry [:khushil324]]

Attachment: Screenshot 2019-04-29 at 6.15.09 PM.png

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9061343 [details] [diff] [review]
Bug-1545907_remove-grid-am-identity-edit.patch

Review of attachment 9061343 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/themes/osx/mail/accountManage.css
@@ +22,4 @@
>  }
>  
>  .signatureBox {
> +  flex-grow: 1;

only on mac?

::: mailnews/base/prefs/content/am-identity-edit.xul
@@ +68,5 @@
>          <groupbox>
>            <label class="header">&publicData.label;</label>
> +          <hbox>
> +            <vbox>
> +              <hbox flex="1" align="center">

probably don't need the align="center"?

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug-1545907_remove-grid-am-identity-edit.patch

Comment 7

[Khushil Mistry [:khushil324]]

Attachment: Screenshot 2019-04-29 at 7.46.11 PM.png

It is looking like this without align=center.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 9061369 [details] [diff] [review]
Bug-1545907_remove-grid-am-identity-edit.patch

Review of attachment 9061369 [details] [diff] [review]:
-----------------------------------------------------------------

Alright, r=mkmelin

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/681a9ef10be9
remove grid usage from am-identity-edit.xul. r=mkmelin