154597 - profile manager uses full paths on Mach-o

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[Mike Pinkerton (not reading bugmail)]

http://lxr.mozilla.org/mozilla/source/profile/src/nsProfileAccess.cpp#1430

needs to also have XP_MACOSX when we land the mach-o file code on the trunk.

Comment 1

[Mike Pinkerton (not reading bugmail)]

i'm making this change now on the chimera branch so that product folders can be
renamed when we change the product name.

Comment 2

[Mike Pinkerton (not reading bugmail)]

never mind, i'm not gonna touch nothing. i'll let conrad deal with it on the
branch as well. ;)

Comment 3

[Conrad Carlen (not reading bugmail)]

Patch coming up. Making bug 118203 depend on this so that, when it hits the
trunk, this comes with.

Comment 4

[Conrad Carlen (not reading bugmail)]

Attachment: patch

The patch makes it so that we first try to use the data as a base64 encoded
alias. Except for a CFM build which, for a few days > a year ago, and the
Chimera build from yesterday, this will succeed. If not, it tries ther data as
a unicode path.

With the patch, the data in the registry will be converted. The first time it's
read in as a path, it will be written out as an alias on the next call to
UpdateRegistry (called by nsProfile::SetCurrentProfile)

Comment 5

[Conrad Carlen (not reading bugmail)]

Can I get r=/sr= on this? I'd like to check it into the Chimera branch today so
we have only 1 day's worth of builds doing this.

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 89436 [details] [diff] [review]
patch

sr=sfraser

Are there other places in the code that have #ifdef XP_MAC calls to
Get/SetPersistentDescriptor?

Comment 7

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 89436 [details] [diff] [review]
patch

looks good

r=pink

Comment 8

[Conrad Carlen (not reading bugmail)]

> Are there other places in the code that have #ifdef XP_MAC calls to
Get/SetPersistentDescriptor?

No, not that I could find.

Comment 9

[Conrad Carlen (not reading bugmail)]

Fixed.

Comment 10

[K'Trina Medina]

Verified code fix