"Recent Closed Tabs" and "Recent Closed Windows" list in Menubar does not show
Status
()
People
(Reporter: alice0775, Assigned: bgrins)
Tracking
(Regression, {nightly-community, regression})
Firefox Tracking Flags
(firefox-esr60 unaffected, firefox66 unaffected, firefox67 unaffected, firefox68 verified)
Details
Attachments
(1 attachment)
Reproducible: always
Steps To Reproduce:
- Close tabs
- Press Alt key > History > Recent Closed Tabs
And
- Open web page in New window(Ctrl+N)
- Close the window
- Press Alt key > History > Recent Closed Windows
Actual Results:
Nothing is displayed
Expected Results:
Closed tabs list should show
Closed windows list should show
Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27157cc6395ef681545b5a8ae5f95fc584f38792&tochange=223a8a0c4eed19547e6e843cfd265c728f7dc7c2
Suspect:
223a8a0c4eed Brian Grinstead — Bug 1519502 - Convert menu bindings to a Custom Element r=surkov
|
Reporter | |
Comment 1•3 months ago
|
||
:bgrins, Your bunch of patch seems to cause the regression. Can you please look into this?
|
Assignee | |
Comment 2•3 months ago
|
||
Thanks for filing. This looks like an easy fix (firstChild -> menupopup): https://searchfox.org/mozilla-central/rev/52b651e168a5b3a923bed0ef977a3fd27c5dd713/browser/base/content/browser-places.js#605. More concerning is the fact no tests failed here - I'll have a look.
|
|
Assignee | |
Comment 3•3 months ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/61587f94c172 Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly r=Gijs
|
||
Updated•3 months ago
|
|
||
Comment 5•3 months ago
|
||
| bugherder | ||
|
||
Comment 6•3 months ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 68.0a1 (2019-04-23), so I'm marking this bug as VERIFIED.
Thank you very much! \o/
Description
•