1545983 - "Recent Closed Tabs" and "Recent Closed Windows" list in Menubar does not show

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Alice0775 White]

Reproducible: always

Steps To Reproduce:

1. Close tabs
2. Press Alt key > History > Recent Closed Tabs

And

1. Open web page in New window(Ctrl+N)
2. Close the window
3. Press Alt key > History > Recent Closed Windows

Actual Results:
Nothing is displayed

Expected Results:
Closed tabs list should show
Closed windows list should show

Regression Window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=27157cc6395ef681545b5a8ae5f95fc584f38792&tochange=223a8a0c4eed19547e6e843cfd265c728f7dc7c2

Suspect:
223a8a0c4eed Brian Grinstead — Bug 1519502 - Convert menu bindings to a Custom Element r=surkov

Comment 1

[Alice0775 White]

:bgrins, Your bunch of patch seems to cause the regression. Can you please look into this?

Comment 2

[Brian Grinstead [:bgrins]]

Thanks for filing. This looks like an easy fix (firstChild -> menupopup): https://searchfox.org/mozilla-central/rev/52b651e168a5b3a923bed0ef977a3fd27c5dd713/browser/base/content/browser-places.js#605. More concerning is the fact no tests failed here - I'll have a look.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1545983 - Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61587f94c172
Update "Recent Closed Tabs" and "Recent Closed Windows" menus to reference their menupopup correctly r=Gijs

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/61587f94c172

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 68.0a1 (2019-04-23), so I'm marking this bug as VERIFIED.
Thank you very much! \o/