1546041 - Should throw a TypeError on attempts to construct Request with mode=navigate

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P2)

Description

[Thomas Wisniewski [:twisniewski]]

Step 18 in the fetch spec for the Request constructor [1] indicates that we should throw a TypeError if mode=navigate, which we currently do not do, thus failing the related WPT.

[1] https://fetch.spec.whatwg.org/#ref-for-dfn-throw%E2%91%A0%E2%91%A7

Comment 1

[Kershaw Chang [:kershaw]]

The code [1] was complied with the spec before, but it was changed in bug 1298823.
This looks like a spec issue to me.

Anne, what do you think?

[1] https://searchfox.org/mozilla-central/rev/d9c74941343fb85bf6e793983268ad4a201b47b6/dom/fetch/Request.cpp#341

Comment 2

[Anne (:annevk)]

Throwing less often was about the first argument being a Request object whose mode is "navigate", right? This is about the second argument being an object whose mode member is "navigate". That should still throw.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1546041 - Throw TypeError if mode is Navigate

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b6338393cc7
Throw TypeError if mode is Navigate r=baku

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 3b6338393cc7 (Bug 1546041) for mochitest failures at test_request.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/6f3ded4cf77287eb566e8ff8d40bb3d272722a0d

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=3b6338393cc72035f69e2804e364080fbdd5a7e5&selectedJob=248509605

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248509605&repo=autoland&lineNumber=3765

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/284a94a4c772
Throw TypeError if mode is Navigate r=baku

Comment 7

[Kershaw Chang [:kershaw]]

(In reply to Cristian Brindusan [:cbrindusan] from comment #5)

Backed out changeset 3b6338393cc7 (Bug 1546041) for mochitest failures at test_request.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/6f3ded4cf77287eb566e8ff8d40bb3d272722a0d

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=3b6338393cc72035f69e2804e364080fbdd5a7e5&selectedJob=248509605

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248509605&repo=autoland&lineNumber=3765

I've fixed the test.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/284a94a4c772