Closed Bug 1546046 Opened 5 years ago Closed 5 years ago

Remove support for XBL <resources>


(Core :: XBL, task, P2)




Tracking Status
firefox68 --- fixed


(Reporter: emilio, Assigned: emilio)




(1 file)

No description provided.

Now that we can remove the last usage in-tree of <xbl:resources> in bug 1470880, we can remove the implementation, yay!

Jordi, fyi. I think this shouldn't affect Thunderbird:

There's a bunch of usage under suite/, but that's about it.

Blocks: war-on-xbl
Type: defect → task
Depends on: 1470880
Flags: needinfo?(jorgk)

Thanks for the heads-up. Yes, we have removed <resources> bit by bit, but there is one left in common/ which would break us.

Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(jorgk)

I think that remaining one is not necessary since button.css is included in widgets.css -

We can't convert the menu-button binding yet since button hasn't yet been de-xbl'd in mozilla-central yet.

Is this a dupe of bug 1474069?

Flags: needinfo?(mkmelin+mozilla)

I'm on removing the last <resource> in common. It needs some tweaks to look like before.

Flags: needinfo?(richard.marti)

I filed bug 1546082 for the remaining <resources> for TB.

Depends on: 1546082

So much unsound code going away :-)

Pushed by
Remove support for XBL resources. r=TYLin
Depends on: 1474070

Backed out changeset e85cb54e5944 (Bug 1546046) complementary backout after 1470880 was backed out

Bug 1546256 was caused by not backing this out alongside 1470880.

Regressions: 1546256
Priority: -- → P2
Pushed by
Remove support for XBL resources. r=TYLin
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.