1546046 - Remove support for XBL <resources>

Status: RESOLVED FIXED

(Core :: XBL, task, P2)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Now that we can remove the last usage in-tree of <xbl:resources> in bug 1470880, we can remove the implementation, yay!

Jordi, fyi. I think this shouldn't affect Thunderbird:

https://searchfox.org/comm-central/search?q=%3Cresources%3E&case=false&regexp=false&path=

There's a bunch of usage under suite/, but that's about it.

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. Yes, we have removed <resources> bit by bit, but there is one left in common/ which would break us.

Comment 3

[Magnus Melin [:mkmelin]]

I think that remaining one is not necessary since button.css is included in widgets.css - https://searchfox.org/comm-central/source/mozilla/toolkit/content/widgets.css#11

We can't convert the menu-button binding yet since button hasn't yet been de-xbl'd in mozilla-central yet.

Is this a dupe of bug 1474069?

Comment 4

[Richard Marti (:Paenglab)]

I'm on removing the last <resource> in common. It needs some tweaks to look like before.

Comment 5

[Richard Marti (:Paenglab)]

I filed bug 1546082 for the remaining <resources> for TB.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1546046 - Remove support for XBL resources. r=TYLin

So much unsound code going away :-)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e85cb54e5944
Remove support for XBL resources. r=TYLin

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset e85cb54e5944 (Bug 1546046) complementary backout after 1470880 was backed out

Bug 1546256 was caused by not backing this out alongside 1470880.

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/integration/autoland/rev/831918f009f63596fde1e532cc0f026d2e53cf78

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1855d66f55a5
Remove support for XBL resources. r=TYLin

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1855d66f55a5

Comment 13

[Intermittent Failures Robot]

1 failures in 4131 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1546046&startday=2019-04-29&endday=2019-05-05&tree=all