Closed Bug 1546046 Opened 4 years ago Closed 4 years ago

Remove support for XBL <resources>

Categories

(Core :: XBL, task, P2)

Product:
Core
Component:
XBL
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1546046 - Remove support for XBL resources. r=TYLin
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

Now that we can remove the last usage in-tree of <xbl:resources> in bug 1470880, we can remove the implementation, yay!

Jordi, fyi. I think this shouldn't affect Thunderbird:

https://searchfox.org/comm-central/search?q=%3Cresources%3E&case=false&regexp=false&path=

There's a bunch of usage under suite/, but that's about it.

Blocks: war-on-xbl
Type: defect → task
Depends on: 1470880
Flags: needinfo?(jorgk)

Thanks for the heads-up. Yes, we have removed <resources> bit by bit, but there is one left in common/ which would break us.

Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(jorgk)

I think that remaining one is not necessary since button.css is included in widgets.css - https://searchfox.org/comm-central/source/mozilla/toolkit/content/widgets.css#11

We can't convert the menu-button binding yet since button hasn't yet been de-xbl'd in mozilla-central yet.

Is this a dupe of bug 1474069?

Flags: needinfo?(mkmelin+mozilla)

I'm on removing the last <resource> in common. It needs some tweaks to look like before.

Flags: needinfo?(richard.marti)

I filed bug 1546082 for the remaining <resources> for TB.

Depends on: 1546082

So much unsound code going away :-)

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e85cb54e5944
Remove support for XBL resources. r=TYLin
Depends on: 1474070

Backed out changeset e85cb54e5944 (Bug 1546046) complementary backout after 1470880 was backed out

Bug 1546256 was caused by not backing this out alongside 1470880.

Regressions: 1546256
Priority: -- → P2
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1855d66f55a5
Remove support for XBL resources. r=TYLin

https://hg.mozilla.org/mozilla-central/rev/1855d66f55a5

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.