about:addons list items with highlights are difficult to read in dark mode

RESOLVED FIXED in Firefox 68

Status

()

Product:
Toolkit
Component:
Themes
Type:
defect
Importance:
P3
normal
Status:
RESOLVED FIXED
Opened:
3 months ago
Updated:
2 months ago

People

(Reporter: ke5trel, Assigned: ke5trel)

Tracking

(Blocks 1 bug)

Version:
unspecified
Target:
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

Addon highlights
125.93 KB, image/png
Details
Bug 1546077 - Fix some background colors and a few other colors in about:addons for dark mode
47 bytes, text/x-phabricator-request
Details | Review
Posted image Addon highlights —

The addon highlights for notifications and pending actions make the text difficult to read in dark mode.

Priority: -- → P3
Depends on: 1544111

Does this issue cover the wrong color used for the "info box"? It should use a white text on black background like in about:preferences.

(In reply to Danny Colin [:sdk] from comment #2)

Does this issue cover the wrong color used for the "info box"?

Yes.

Keywords: checkin-needed

There is a code conflict. Please update the patch and resubmit. Thank you.

Flags: needinfo?(ke5trel)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1b3ddfeda3ba
Fix some background colors and a few other colors in about:addons for dark mode r=dao

Thanks, Tim.

Flags: needinfo?(ke5trel)

https://hg.mozilla.org/mozilla-central/rev/1b3ddfeda3ba

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.