Closed
Bug 1546101
Opened 5 years ago
Closed 5 years ago
about-telemetry-settings-explanation is passed the wrong argument parameters, breaking telemetry channel ("release" vs "pre-release" data) information in about:telemetry
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox66 | --- | unaffected |
firefox67 | --- | unaffected |
firefox68 | --- | fixed |
People
(Reporter: Gijs, Assigned: nautilus)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
The console indicates:
console.warn: "[fluent][resolver] errors in en-US/about-telemetry-settings-explanation: ReferenceError: Unknown variable: channel."
This is because
about-telemetry-settings-explanation = Telemetry is collecting { about-telemetry-data-type } and upload is <a data-l10n-name="upload-link">{ about-telemetry-upload-type }</a>.
includes about-telemetry-data-type
, and that looks like this:
# Selects the correct release version
# Variables:
# $channel (String): represents the corresponding release data string
about-telemetry-data-type =
{ $channel ->
[release] release data
*[prerelease] pre-release data
}
so it expects a "channel" property on the l10n-args object we pass, but https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/content/aboutTelemetry.js#212 passes a datacase
and uploadcase
instead. Looks like datacase
should be channel
in the JS.
Avery, can you or one of your colleagues pick this up?
Flags: needinfo?(berning5)
Updated•5 years ago
|
Assignee: nobody → nickcowles9575
Status: NEW → ASSIGNED
Flags: needinfo?(berning5)
Comment 1•5 years ago
|
||
Type: defect → task
Reporter | ||
Comment 2•5 years ago
|
||
This is a user-visible thing once 68 goes to beta/release (because the string is set up to default to pre-release which happens to be OK on nightly).
Type: task → defect
Summary: about-telemetry-settings-explanation is passed the wrong argument parameters → about-telemetry-settings-explanation is passed the wrong argument parameters, breaking telemetry channel ("release" vs "pre-release" data) information in about:telemetry
Updated•5 years ago
|
status-firefox66:
--- → unaffected
status-firefox67:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Updated•5 years ago
|
Assignee: nickcowles9575 → freychr3
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f9ccfa09fb6d Fixing argument paramater passed to about-telemetry-settings-explanation to fix release vs pre-release info in about:telemetry r=Gijs
Comment 5•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•2 years ago
|
Has Regression Range: --- → yes
Updated•2 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•