1546101 - about-telemetry-settings-explanation is passed the wrong argument parameters, breaking telemetry channel ("release" vs "pre-release" data) information in about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[:Gijs (he/him)]

The console indicates:

console.warn: "[fluent][resolver] errors in en-US/about-telemetry-settings-explanation: ReferenceError: Unknown variable: channel."

This is because

https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/locales/en-US/toolkit/about/aboutTelemetry.ftl#72

about-telemetry-settings-explanation = Telemetry is collecting { about-telemetry-data-type } and upload is <a data-l10n-name="upload-link">{ about-telemetry-upload-type }</a>.

includes about-telemetry-data-type, and that looks like this:

https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/locales/en-US/toolkit/about/aboutTelemetry.ftl#43-50

# Selects the correct release version
# Variables:
#   $channel (String): represents the corresponding release data string
about-telemetry-data-type =
    { $channel ->
        [release] release data
       *[prerelease] pre-release data
    }

so it expects a "channel" property on the l10n-args object we pass, but https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/content/aboutTelemetry.js#212 passes a datacase and uploadcase instead. Looks like datacase should be channel in the JS.

Avery, can you or one of your colleagues pick this up?

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[:Gijs (he/him)]

This is a user-visible thing once 68 goes to beta/release (because the string is set up to default to pre-release which happens to be OK on nightly).

Comment 3

[Chris Frey [:nautilus]]

Attachment: Bug 1546101 - Fixing argument paramater passed to about-telemetry-settings-explanation to fix release vs pre-release info in about:telemetry

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9ccfa09fb6d
Fixing argument paramater passed to about-telemetry-settings-explanation to fix release vs pre-release info in about:telemetry r=Gijs

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f9ccfa09fb6d