1546155 - Disabled labels on proxy dialog have low contrast in dark mode

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Tim Nguyen :ntim]

Attachment: image.png

Comment 1

[Kestrel]

This must be Mac-only, it uses color: GrayText which is rgb(150, 150, 150) on Ubuntu 19.04 and rgb(109, 109, 109) on Windows 10 which both have reasonable contrast.

Comment 2

[Tim Nguyen :ntim]

(In reply to Kestrel from comment #1)

This must be Mac-only, it uses color: GrayText which is rgb(150, 150, 150) on Ubuntu 19.04 and rgb(109, 109, 109) on Windows 10 which both have reasonable contrast.

Yeah, but we should really make it use color: inherit; here, GrayText changes based on your system theme on Linux/Windows (GTK themes, high contrast themes etc.)

Comment 3

[Kestrel]

Attachment: Bug 1546155 - Fix in-content disabled label color and opacity for dark mode

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8db7a4d48e49
Fix in-content disabled label color and opacity for dark mode r=dao

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8db7a4d48e49