Closed Bug 1546155 Opened 3 years ago Closed 2 years ago

Disabled labels on proxy dialog have low contrast in dark mode

Categories

(Firefox :: Theme, defect, P3)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: ntim, Assigned: ke5trel)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

image.png
128.80 KB, image/png
Details
Bug 1546155 - Fix in-content disabled label color and opacity for dark mode
47 bytes, text/x-phabricator-request
Details | Review
Attached image image.png —
No description provided.

This must be Mac-only, it uses color: GrayText which is rgb(150, 150, 150) on Ubuntu 19.04 and rgb(109, 109, 109) on Windows 10 which both have reasonable contrast.

(In reply to Kestrel from comment #1)

This must be Mac-only, it uses color: GrayText which is rgb(150, 150, 150) on Ubuntu 19.04 and rgb(109, 109, 109) on Windows 10 which both have reasonable contrast.

Yeah, but we should really make it use color: inherit; here, GrayText changes based on your system theme on Linux/Windows (GTK themes, high contrast themes etc.)

Priority: -- → P3
Assignee: nobody → ke5trel
Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8db7a4d48e49
Fix in-content disabled label color and opacity for dark mode r=dao

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/8db7a4d48e49

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.