1546169 - Enable 64-bit atomics on additional platforms

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Robin Templeton [:terpri]]

In some configurations, SpiderMonkey doesn't provide 64-bit atomic operations required for BigInt. For example, when compiling for x86-64 with Ion disabled, jit/shared/AtomicOperations-feeling-lucky-gcc.h defines 64-bit operations that simply call MOZ_CRASH.

Comment 1

[Robin Templeton [:terpri]]

Attachment: Enable 64-bit atomics for more platforms in AtomicOperations-feeling-lucky-gcc.h.

Comment 2

[Arthur Iakab [arthur_iakab]]

Tried to land this but received this error message We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpoT5fQo\npatching file js/src/jit/shared/AtomicOperations-feeling-lucky-gcc.h\nHunk #1 FAILED at 41\n1 out of 2 hunks FAILED -- saving rejects to file js/src/jit/shared/AtomicOperations-feeling-lucky-gcc.h.rej\nabort: patch failed to apply', '')

Robin can you please take a look?

Comment 3

[Robin Templeton [:terpri]]

Please try landing this again; I rebased it onto a more recent version of mozilla-central

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e3eef30f66b
Enable 64-bit atomics for more platforms in AtomicOperations-feeling-lucky-gcc.h. r=lth

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e3eef30f66b