Closed Bug 1546169 Opened 2 years ago Closed 2 years ago

Enable 64-bit atomics on additional platforms

Categories

(Core :: JavaScript Engine, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: terpri, Assigned: terpri)

References

Details

Attachments

(1 file)

In some configurations, SpiderMonkey doesn't provide 64-bit atomic operations required for BigInt. For example, when compiling for x86-64 with Ion disabled, jit/shared/AtomicOperations-feeling-lucky-gcc.h defines 64-bit operations that simply call MOZ_CRASH.

Assignee: nobody → robin
Blocks: 1531647
Attachment #9059919 - Attachment description: Enable 64-bit atomics by default in AtomicOperations-feeling-lucky-gcc.h. → Enable 64-bit atomics for more platforms in AtomicOperations-feeling-lucky-gcc.h.
Keywords: checkin-needed

Tried to land this but received this error message We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpoT5fQo\npatching file js/src/jit/shared/AtomicOperations-feeling-lucky-gcc.h\nHunk #1 FAILED at 41\n1 out of 2 hunks FAILED -- saving rejects to file js/src/jit/shared/AtomicOperations-feeling-lucky-gcc.h.rej\nabort: patch failed to apply', '')

Robin can you please take a look?

Flags: needinfo?(robin)

Please try landing this again; I rebased it onto a more recent version of mozilla-central

Flags: needinfo?(robin)
Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e3eef30f66b
Enable 64-bit atomics for more platforms in AtomicOperations-feeling-lucky-gcc.h. r=lth

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.