Fix live-sites support when running Raptor cold page-load on android

RESOLVED FIXED in Firefox 68

Status

defect
P1
normal
RESOLVED FIXED
a month ago
29 days ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

Version 3
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a month ago

When support for running Raptor page-load with live-sites was added previously (Bug 1531169) only warm page-load existed; now get live-sites support working with cold page-load.

When running Raptor cold page-load on Fenix with live sites (i.e. set 'use_live_sites = true' in the raptor-tp6m-cold-X.ini) it fails out on the 2nd browser cycle with:

19:35:44 INFO - File "/builds/task_1555961625/workspace/build/tests/raptor/raptor/raptor.py", line 767, in run_test_cold
19:35:44 INFO - self.copy_cert_db(local_cert_db_dir, self.config['local_profile_dir'])
19:35:44 INFO - UnboundLocalError: local variable 'local_cert_db_dir' referenced before assignment
19:35:44 ERROR - Return code: 1

It shouldn't copy (and try to restore) the ssl cert db at all because mozproxy isn't being used.

Try run that demonstrates the failure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=492ec58d37ca5085e1a717072a18c75a2d98d9bd&selectedJob=241853786

Comment 3

29 days ago
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74d827325fbe
Fix live-sites support when running Raptor cold page-load on android; r=davehunt

Comment 4

29 days ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.