Closed Bug 1546265 Opened 5 months ago Closed 5 months ago

Fix the About Dialog and About Preferences BITS download failure tests

Categories

(Toolkit :: Application Update, defect, P2)

Product:
Toolkit
Component:
Application Update
Version:
68 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(1 file)

Bug 1546265 - Fixes for the About Dialog and About Preferences BITS download failure tests. r=bytesized
47 bytes, text/x-phabricator-request
Details | Review

I have a patch for bug 1540188 that gets most of the existing browser chrome update download tests working using BITS to download the update. The tests that aren't working yet are the BITS download failure tests. This bug is to diagnose and fix those tests.

Version: 59 Branch → 68 Branch

The main bug that was causing this is bug 1546512 which has landed. I'm going to just fix the remaining About Dialog and About Preferences tests in this bug.

Summary: Diagnose and fix tests for BITS download failures → Fix the About Dialog and About Preferences BITS download failure tests

Adds a new step parameter for download information named downloadInfo.
Adds checks for both nsIIncrementalDownload and BITS download result codes.
Makes 8 tests run using BITS for the update download.
Adds test tags for bits and internal browser chrome tests.
Removes the duplicate logging from UpdateService.jsm when running tests locally.

Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41ac1be62749
Fixes for the About Dialog and About Preferences BITS download failure tests. r=bytesized

https://hg.mozilla.org/mozilla-central/rev/41ac1be62749

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.