1546273 - freebl/ecl uses malloc/free

Status: NEW

(NSS :: Libraries, defect, P3)

Description

[Mike Hommey [:glandium]]

While working on bug 1531887, I found that freebl/ecl/ecl.c, ecl_gf.c and ecp_jm.c are using malloc/free rather than PR_Malloc/PR_Free like other parts of NSS (and even freebl). I don't think this is expected.

Comment 1

[Mike Hommey [:glandium]]

Or PORT_Alloc/PORT_Free.

Comment 2

[J.C. Jones [:jcj] (he/they)]

Let's get this cleaned up next cycle. Thanks for the catch, Mike.

Comment 3

[Jenine (she/her)]

Hello - Mike, I'm thinking of looking at this but just got a bit thrown over the mention of the PR_ and PORT_ methods (I'm new to the codebase so apologies if I'm overlooking anything).

For example, I can see PORT_Alloc calls PR_Malloc but PR_Malloc may call malloc() or a zone allocator (I'm not sure what that is either but that's from a first glance without reading the code further).

When would you use the PORT_ methods over the PR_ methods?

Comment 4

[Mike Hommey [:glandium]]

NSS should probably always use PORT_Alloc.

Comment 5

[Marcus Burghardt]

Yes, PORT_ is desired.

Comment 6

[Jenine (she/her)]

Thanks for the replies! I'm looking at another ticket right now but if this one is still unassigned when I'm next free to pick up something, I'll give an update here

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Probably not a P1