console.assert text is purple, should be red (like Errors' text)
Categories
(DevTools :: Console, defect, P3)
Tracking
(firefox68 verified)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | verified |
People
(Reporter: nchevobbe, Assigned: mr.a.thewizard, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [qa-68b-p2])
Attachments
(1 file)
Steps to reproduce
- Open the console
- Evaluate
console.assert(false, "you failed")
Expected results
There's an "Assertion failed" message, similar to an error message
Actual results
We do show the message, but the text is purple.
It's purple because we use the cm-variable class on the element, in devtools/client/webconsole/components/message-types/ConsoleApiCall.js#85.
Removing the className property on the config object in dom.span should make it looks right.
(In reply to mr.a.thewizard from comment #1)
I shall take this bug.
Hi, this is my first open source contribution can you provide with some documentation for cloning the project, testing it and raising a pull request.
|
Reporter | |
Comment 4•5 years ago
|
||
Hello Mr. Wizard :)
You can setup the work environment reading http://docs.firefox-dev.tools/getting-started/ , it should have everything you need to clone, build and ask for review on a patch.
When asked, make sure to use Artifact builds as it's faster to work with.
Don't hesitate to ask any question, either here or on Slack.
Hi Mr. Chevobbe,
I fixed the bug but I cannot test the file, when I am trying to give command
"./mach test devtools/client/webconsole/components/message-types/ConsoleApiCall.js"
It is throwing an error that it is unable to find tests
I didn't find any test files addressing this file.
|
|
Reporter | |
Comment 7•5 years ago
|
||
clearing needinfo since we discussed on Slack
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3328e1d9b48e Remove the className for the console.assert element. r=nchevobbe.
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Comment 11•5 years ago
|
||
Confirmed issue with 68.0a1 (2019-04-22).
Fix verified with 70.0a1 (2019-08-08), 68.0.1 on Windows 10, macOS 10.13, Ubuntu 18.04.
Description
•