1546281 - remove grid usage from comm/mailnews/base/prefs/content/am-server.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Comment 1

[Khushil Mistry [:khushil324]]

Attachment: Bug-1546281_remove-grid-am-server.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9061394 [details] [diff] [review]
Bug-1546281_remove-grid-am-server.patch

Review of attachment 9061394 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/am-server.xul
@@ +17,3 @@
>        title="&serverSettings.label;"
>        onload="parent.onPanelLoaded('am-server.xul');">
> +  <html:style>

I think it would be better to put the css into a am-server.css file (next to the xul file)

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1546281_remove-grid-am-server.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9061649 [details] [diff] [review]
Bug-1546281_remove-grid-am-server.patch

Review of attachment 9061649 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin with the boilerplate added

::: mailnews/base/prefs/content/am-server.css
@@ +1,1 @@
> +#amServerSetting {

This file is missing the MPL boilerplace. Look at e.g. accountManage.css

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1546281_remove-grid-am-server.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/17a0eac83bc5
remove grid usage from am-server.xul. r=mkmelin DONTBUILD