Closed Bug 1546281 Opened 3 years ago Closed 3 years ago

remove grid usage from comm/mailnews/base/prefs/content/am-server.xul

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: khushil324, Assigned: khushil324)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → khushil324
Type: defect → task
Attachment #9061394 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9061394 [details] [diff] [review]
Bug-1546281_remove-grid-am-server.patch

Review of attachment 9061394 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/am-server.xul
@@ +17,3 @@
>        title="&serverSettings.label;"
>        onload="parent.onPanelLoaded('am-server.xul');">
> +  <html:style>

I think it would be better to put the css into a am-server.css file (next to the xul file)
Attachment #9061394 - Flags: review?(mkmelin+mozilla) → feedback+
Attachment #9061394 - Attachment is obsolete: true
Attachment #9061649 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9061649 [details] [diff] [review]
Bug-1546281_remove-grid-am-server.patch

Review of attachment 9061649 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin with the boilerplate added

::: mailnews/base/prefs/content/am-server.css
@@ +1,1 @@
> +#amServerSetting {

This file is missing the MPL boilerplace. Look at e.g. accountManage.css
Attachment #9061649 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9061649 - Attachment is obsolete: true
Attachment #9062260 - Flags: review+
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 68.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/17a0eac83bc5
remove grid usage from am-server.xul. r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Regressions: 1565703
Regressions: 1586572
You need to log in before you can comment on or make changes to this bug.