1546311 - Favicons are not displayed for bookmarked pages from the Top Stories section from about:newtab

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[Mihai Boldan, QA [:mboldan]]

Affected versions

• Firefox 66.0.3
• Firefox 67.0b13
• Firefox 68.0a1 (2019-04-22)

Affected platforms

• macOS 10.14.3
• Ubuntu 18.04x64
• Windows 10x64

Prerequisites
Set browser.search.region to US in about:config.

Steps to reproduce

1. Launch Firefox.
2. Hover over a Top Stories tile.
3. Click on the "..." more button and select 'Bookmark' button.
4. Click 'Save' button and observe the saved bookmark.

Expected result

• The page is correctly bookmarked and the favicon is displayed.

Actual result

• The favicon is not displayed for the bookmarked page.

Regression range

• To be determined soon. The issue is also reproducible on latest RC build.

Additional notes

• The favicon is correctly loaded after the bookmarked page is visited.

Comment 1

[Mark Banner (:standard8)]

For bookmarks this is expected behaviour - if you don't load the site, then we won't get the favicon for it (until you first load it).

You could argue in the top site case that we should have the bookmark, and so I think this would be the new tab page responsibility to provide.

Comment 2

[Negritas Sergiu]

I tried to find a regression for this issue following the STR from the description, here is the pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8645a74bbbd06b67699317df1abf3897db0e43d5&tochange=8e818b5e9b6bef0fc1a5c527ecf30b0d56a02f14. I found that the issue is reproducible from when the "Top Sites" feature was implemented, and also in the description on step 3 the menu from "..." doesn't have the "Bookmark" option so in order to reproduce the issue I had to right-click and click on the "Bookmark This Link" option.