1546319 - Missing Get Element Property tests for mutated web content

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P1)

Description

[Andreas Tolfsen ❲:ato❳]

We have quite few tests for Get Element Property in general, but
specifically we’re missing tests for returning properties that have
been mutated by executed scripts.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1546319: webdriver: sanitise get_element_property/get.py;

Nothing remarkable in this patch.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1546319: webdriver: add Get Element Property tests for mutated web content;

There are approximately zero coverage for properties modified or set
by web content and through script evaluation. The only succcess
path test for Get Element Property is test_element, but it checks
an attribute already present in the prototype of the HTMLInputElement.

This patch adds tests where the property is defined through web
content. This uncovers a defect in Firefox, where Get Element
Property seemingly operates on the initial value of the attribute.

Comment 3

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b00a607b717c109f25e94224d1cb8a9e6b300fa

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f81199595401
webdriver: sanitise get_element_property/get.py; r=automatedtester
https://hg.mozilla.org/integration/autoland/rev/728a88d61132
webdriver: add Get Element Property tests for mutated web content; r=automatedtester

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f81199595401
https://hg.mozilla.org/mozilla-central/rev/728a88d61132

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16526 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged