if you collapse the message pane, the security status can be misleading

VERIFIED FIXED in Future

Status

MailNews Core
Security: S/MIME
P1
normal
VERIFIED FIXED
16 years ago
9 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: kaie)

Tracking

1.0 Branch
Future
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

3.52 KB, patch
Jean-Francois Ducarroz
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
if you collapse the message pane, the security status can be misleading

steps to reproduce:

open mail, with the message pane open.
view a signed message.
hide the message pane
click on a message that isn't signed.

the security status will still show that the message is signed, and if you 
click on the security status area, it will give you status about the signed 
message, not the message you have currently selected in the thread pane.

I think the fix is to clear (or hide) the security status area when the message 
pane is hidden.

Comment 1

16 years ago
S/MIME
Assignee: ssu → ssaux
Component: Security: General → S/MIME
Product: MailNews → PSM
QA Contact: junruh → carosendahl
Version: other → 2.3

Comment 2

16 years ago
Confirmed.  Seth's suggestion to clear/hide the status bar since it is no longer
active when the message pane is not viewable is correct.

Comment 3

16 years ago
Kai.
Nominate for buffy.
Assignee: ssaux → kaie
Keywords: nsbeta1
Priority: -- → P1

Updated

16 years ago
Target Milestone: --- → Future
(Assignee)

Updated

16 years ago
Keywords: nsbeta1 → nsbeta1+
(Assignee)

Comment 4

16 years ago
Created attachment 95517 [details] [diff] [review]
Patch v1

This should fix it.
Seth, can you please r/sr?
Comment on attachment 95517 [details] [diff] [review]
Patch v1

sr=sspitzer
Attachment #95517 - Flags: superreview+
Comment on attachment 95517 [details] [diff] [review]
Patch v1

R=ducarroz
Attachment #95517 - Flags: review+
(Assignee)

Comment 7

16 years ago
Fixed on trunk.

The status bar icons should automatically hide, regardless which method to hide
the message pane is used. I tested:
- use menu
- drag the splitter

When you unhide the pane, and there is still the same message selected in the
message list, the security status of that message should automatically reappear.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 8

16 years ago
if (gDBView) {
  gDBView.suppressMsgDisplay = now_hidden;
}
NotifyChangedMessagePaneVisibility(now_hidden);

is duplicated; in theory you could move the if(){} into the common function.

Comment 9

16 years ago
Verified - status bar now behaves correctly using either menu or gui based
functions.

20020904 Trunk Build
Status: RESOLVED → VERIFIED

Updated

13 years ago
Component: Security: S/MIME → Security: S/MIME
Product: PSM → Core

Updated

10 years ago
Version: psm2.3 → 1.0 Branch

Updated

9 years ago
Component: Security: S/MIME → Security: S/MIME
Product: Core → MailNews Core
QA Contact: carosendahl → s.mime
You need to log in before you can comment on or make changes to this bug.