Closed Bug 154634 Opened 22 years ago Closed 22 years ago

if you collapse the message pane, the security status can be misleading

Categories

(MailNews Core :: Security: S/MIME, defect, P1)

1.0 Branch
x86
Windows 2000
defect

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: sspitzer, Assigned: KaiE)

Details

Attachments

(1 file)

if you collapse the message pane, the security status can be misleading

steps to reproduce:

open mail, with the message pane open.
view a signed message.
hide the message pane
click on a message that isn't signed.

the security status will still show that the message is signed, and if you 
click on the security status area, it will give you status about the signed 
message, not the message you have currently selected in the thread pane.

I think the fix is to clear (or hide) the security status area when the message 
pane is hidden.
S/MIME
Assignee: ssu → ssaux
Component: Security: General → S/MIME
Product: MailNews → PSM
QA Contact: junruh → carosendahl
Version: other → 2.3
Confirmed.  Seth's suggestion to clear/hide the status bar since it is no longer
active when the message pane is not viewable is correct.
Kai.
Nominate for buffy.
Assignee: ssaux → kaie
Keywords: nsbeta1
Priority: -- → P1
Target Milestone: --- → Future
Keywords: nsbeta1nsbeta1+
Attached patch Patch v1Splinter Review
This should fix it.
Seth, can you please r/sr?
Comment on attachment 95517 [details] [diff] [review]
Patch v1

sr=sspitzer
Attachment #95517 - Flags: superreview+
Comment on attachment 95517 [details] [diff] [review]
Patch v1

R=ducarroz
Attachment #95517 - Flags: review+
Fixed on trunk.

The status bar icons should automatically hide, regardless which method to hide
the message pane is used. I tested:
- use menu
- drag the splitter

When you unhide the pane, and there is still the same message selected in the
message list, the security status of that message should automatically reappear.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
if (gDBView) {
  gDBView.suppressMsgDisplay = now_hidden;
}
NotifyChangedMessagePaneVisibility(now_hidden);

is duplicated; in theory you could move the if(){} into the common function.
Verified - status bar now behaves correctly using either menu or gui based
functions.

20020904 Trunk Build
Status: RESOLVED → VERIFIED
Product: PSM → Core
Version: psm2.3 → 1.0 Branch
Product: Core → MailNews Core
QA Contact: carosendahl → s.mime
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: