Closed Bug 1546347 Opened 5 years ago Closed 4 years ago

Message location on CSS Warnings has an erroneous title attribute

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: nchevobbe, Assigned: armando.ferreira, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1546347 - Message location on CSS Warnings has an erroneous title attribute. r=nchevobbe
47 bytes, text/x-phabricator-request
Details | Review

Steps to reproduce

  1. Navigate to data:text/html,<meta charset=utf8><style>h1{color: redd;}</style>
  2. Open the webconsole
  3. Turn on the CSS filter
  4. On the Expected color but found ‘redd’. message, hover the location link on the right

Expected results

A tooltip is displayed saying View source in Style Editor

Actual results

A tooltip is displayed saying View source in Debugger

This comes from devtools/client/shared/components/Frame.js#219 where we assume we're always dealing with JS location, which is wrong.

Hi Nicolas, Can I take this bug?

Flags: needinfo?(nchevobbe)

Sure Armando, I assigned it to you :)

Assignee: nobody → armando.ferreira
Flags: needinfo?(nchevobbe)

Adding a new opcional property to Frame.js, messageSource, which will allows us to know the source of the Message. We will be using this property to display the correct tooltip message.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/948773b53aec
Message location on CSS Warnings has an erroneous title attribute. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/948773b53aec

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.