Report Problems panel still displays the description after sending the report

VERIFIED FIXED in Firefox 67

Status

()

defect
P1
normal
VERIFIED FIXED
28 days ago
26 days ago

People

(Reporter: ccomorasu, Assigned: ntim)

Tracking

(Blocks 1 bug, Regression, {regression})

Trunk
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox66 unaffected, firefox67 verified, firefox68 verified)

Details

Attachments

(1 attachment)

Affected versions

  • Fx 67.0b13
  • Fx 68.0a1

Affected platforms

  • Windows 10 x64
  • Ubuntu 18.04 LTS
  • macOS 10.13

Steps to reproduce

  1. Launch Firefox.
  2. Go to about:preferences#privacy.
  3. From the Content blocking area select the following options: Custom -> Cookies -> All cookies.
  4. Go to https://edition.cnn.com/ and open the Site Information panel.
  5. Click on "Report a problem", type a comment then click on "Send Report".
  6. Open the "Report Problems" panel again.

Expected result

  • The comment from step 5 is submitted.

Actual result

  • The comment from step 5 is still displayed.

Regression range

Has Regression Range: --- → yes
Has STR: --- → yes

(In reply to Cristian Comorasu, QA [:ccomorasu], Release Desktop QA from comment #0)

Regression range

The only patch in this range is just changing a reftest annotation, which can't have caused this bug. So the bisection result must be wrong. Setting flags to request another regression window.

Has Regression Range: yes → no
No longer regressed by: 1531532

Thank you, Kartikaya!
I will look into it as soon as possible.

No longer regressed by: 1531532

Comment 3

27 days ago

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=21e12842278a9d81100aafb8388ab53d90172190&tochange=9b7d9eccb34e0593c0b13e163469c37d396ccaee

Regressed by: 9b7d9eccb34e Tim Nguyen — Bug 1513343 - Remove textarea binding and replace usages with html:textarea. r=bgrins,dao

:ntim,
Your patch seems to cause the regression. Can you please look into this?

Flags: needinfo?(ntim.bugs)
Regressed by: 1513343

Without having looked deeply into this, my guess this that

So now we should probably add an else at https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/browser/base/content/browser-contentblocking.js#1013 that clears the value if the report was successful.

Assignee

Updated

27 days ago
Flags: needinfo?(ntim.bugs)
Assignee

Updated

27 days ago
Assignee: nobody → ntim.bugs

Comment 6

27 days ago
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/99ad1e5017af
Clear report textarea when report is submitted. r=bgrins
Assignee

Comment 7

27 days ago

Comment on attachment 9060172 [details]
Bug 1546367 - Clear report textarea when report is submitted. r=bgrins

Beta/Release Uplift Approval Request

  • User impact if declined: "Report breakage" subview does not clear the comments field when the report is submitted resulting in confusing user experience.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risk, one line change covered by a new test
  • String changes made/needed: none
Attachment #9060172 - Flags: approval-mozilla-beta?

Comment 8

27 days ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 27 days ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Priority: -- → P1

Comment on attachment 9060172 [details]
Bug 1546367 - Clear report textarea when report is submitted. r=bgrins

Minimal patch, low risk but fixes a visible bug for the end user, uplift approved for 67 beta 14, thanks.

Attachment #9060172 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I can confirm this issue is fixed.
I verified on Fx 68.0a1 and Fx 67.0b14 using Ubuntu 18.04 LTS, macOS 10.14.3, Windows 10 x64 and Windows 7 x32.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.