1546433 - clean up Elasticsearch index management code

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

The Elasticsearch code is kind of all over everywhere and it'll make upgrading to a more recent Elasticsearch if it was tidier.

For example, there are several Socorro Apps and modules related to deleting indices. One deletes old indices and one deletes all indices and they use and reuse bits and pieces here and there.

Another example is that there are two methods related to creating indices (though they're called indexes there) and neither have helpful docstrings and they're sort of used interchangeably in the code base.

There are multiple configuration settings involved and they're in different places.

This bug covers refactoring index management related code and configuration and putting everything in ConnectionContext.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I just did part of this, so I'm going to grab it and do the rest.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4904: bug 1546433: refactor Elasticsearch index creation code

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #4904: "bug 1546433: refactor Elasticsearch index creation code" in 173291d.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4907: bug 1546433: refactor Elasticsearch index delete code

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #4907: "bug 1546433: refactor Elasticsearch index delete code" in 518f0e3.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

This has been deployed to prod.