Closed Bug 1546474 Opened 5 years ago Closed 5 years ago

Use aria-label in addition to title for block button in snippet templates

Categories

(Firefox :: Messaging System, enhancement, P1)

Product:
Firefox
Component:
Messaging System
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Flags:
Tracking Status
firefox67 --- fixed
firefox68 --- verified

People

(Reporter: k88hudson, Assigned: rrosario)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4929
52 bytes, text/x-github-pull-request
Details | Review

title is not sufficient to make the block button screen-readable, let's add an aria-label property that contains the block text as well.

Assignee: nobody → rrosario
Iteration: --- → 68.3 - Apr 15 - 28
Priority: -- → P1
Target Milestone: --- → Firefox 68
Summary: Use aria-label for block button in snippet templates, not title → Use aria-label in addition to title for block button in snippet templates
Blocks: 1546808
Type: defect → enhancement

https://hg.mozilla.org/mozilla-central/rev/45c374ffa2a1

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED

I have verified this issue with the latest Firefox Nightly (68.0a1 Build ID - 20190429215338) installed, on Windows 10 x64, Arch Linux and Mac 10.14.4. Now, an aria-label property that contains the block text is displayed when hovering the "Dismiss" button.

Status: RESOLVED → VERIFIED
status-firefox68: fixed → verified
Blocks: 1548042
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: