1546505 - Remove ImageBitmapUtils.cpp and ImageBitmapColorUtils.cpp as they seem to be dead code

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P3)

Description

[Jason Kratzer [:jkratzer]]

The ImageBitmapUtils.cpp and ImageBitmapColorUtils.cpp both seem to be leftover from FoxEye. See bug 1100203 and bug 1141979.

ImageBitmapUtils.cpp has 0% coverage as per:
https://codecov.io/gh/mozilla/gecko-dev/src/5a3e7f1d0b6d0dac4606f82c37a5da7116b5eafa/dom/canvas/ImageBitmapUtils.cpp

And ImageBitmapColorUtils.cpp only appears to be used via the gtest at:
dom/canvas/gtest/TestImageBitmapColorUtils.cpp

Can someone please confirm if this code is in fact dead? If so, it should be removed.

Comment 1

[Jason Kratzer [:jkratzer]]

If the above is in fact, dead code - I also suspect that the following is as well:
https://searchfox.org/mozilla-central/source/dom/canvas/ImageBitmap.cpp#484

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Yes we don't ever use the surface formats that the conversion method in comment 1 indicates. I'll remove this quickly.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1546505 - Remove ImageBitmapUtils and ImageBitmapColorUtils as it is dead code.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f630333b81b8
Remove ImageBitmapUtils and ImageBitmapColorUtils as it is dead code. r=lsalzman

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f630333b81b8