Closed Bug 1546505 Opened 7 months ago Closed 7 months ago

Remove ImageBitmapUtils.cpp and ImageBitmapColorUtils.cpp as they seem to be dead code

Categories

(Core :: Canvas: 2D, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jkratzer, Assigned: aosmond)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The ImageBitmapUtils.cpp and ImageBitmapColorUtils.cpp both seem to be leftover from FoxEye. See bug 1100203 and bug 1141979.

ImageBitmapUtils.cpp has 0% coverage as per:
https://codecov.io/gh/mozilla/gecko-dev/src/5a3e7f1d0b6d0dac4606f82c37a5da7116b5eafa/dom/canvas/ImageBitmapUtils.cpp

And ImageBitmapColorUtils.cpp only appears to be used via the gtest at:
dom/canvas/gtest/TestImageBitmapColorUtils.cpp

Can someone please confirm if this code is in fact dead? If so, it should be removed.

Type: defect → task

If the above is in fact, dead code - I also suspect that the following is as well:
https://searchfox.org/mozilla-central/source/dom/canvas/ImageBitmap.cpp#484

Yes we don't ever use the surface formats that the conversion method in comment 1 indicates. I'll remove this quickly.

Assignee: nobody → aosmond
Priority: -- → P3
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f630333b81b8
Remove ImageBitmapUtils and ImageBitmapColorUtils as it is dead code. r=lsalzman
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.