static bool sNewCertErrorPageEnabled declared in AboutRedirector.h is unused/unreferenced

RESOLVED FIXED in Firefox 68

Status

()

defect
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jaws, Assigned: marian.meireles, Mentored)

Tracking

(Regression, {good-first-bug})

Trunk
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Ah, good find, thank you. That doesn't look harmful so let's turn it into a good first bug...

Mentor: jhofmann
Flags: needinfo?(jhofmann)
Keywords: good-first-bug
Priority: -- → P3
Assignee

Comment 2

2 months ago

Hey Johann, what should I do in this one?
Check if the variable is really unesed and then erase it?
Thanks!

Flags: needinfo?(jhofmann)

(In reply to Mariana Meireles from comment #2)

Hey Johann, what should I do in this one?
Check if the variable is really unesed and then erase it?
Thanks!

The variable is unused so it can safely be deleted.

Flags: needinfo?(jhofmann)
Assignee

Comment 4

2 months ago

Thanks for the answer Jared.
Here's the patch: https://phabricator.services.mozilla.com/D28820

Flags: needinfo?(jaws)

Comment 5

2 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00fcbf4c4aac
Removes unused variable sNewCertErrorPageEnabled r=jaws
Assignee: nobody → marian.meireles
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)

Comment 7

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.