Closed Bug 1546521 Opened 2 years ago Closed 2 years ago

static bool sNewCertErrorPageEnabled declared in AboutRedirector.h is unused/unreferenced

Categories

(Firefox :: Security, defect, P3)

Product:
Firefox
Component:
Security
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: jaws, Assigned: marian.meireles, Mentored)

References

(Regression)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Bug 1546521 - Removes unused variable sNewCertErrorPageEnabled
47 bytes, text/x-phabricator-request
Details | Review

Ah, good find, thank you. That doesn't look harmful so let's turn it into a good first bug...

Mentor: jhofmann
Flags: needinfo?(jhofmann)
Keywords: good-first-bug
Priority: -- → P3

Hey Johann, what should I do in this one?
Check if the variable is really unesed and then erase it?
Thanks!

Flags: needinfo?(jhofmann)

(In reply to Mariana Meireles from comment #2)

Hey Johann, what should I do in this one?
Check if the variable is really unesed and then erase it?
Thanks!

The variable is unused so it can safely be deleted.

Flags: needinfo?(jhofmann)

Thanks for the answer Jared.
Here's the patch: https://phabricator.services.mozilla.com/D28820

Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00fcbf4c4aac
Removes unused variable sNewCertErrorPageEnabled r=jaws
Assignee: nobody → marian.meireles
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)

https://hg.mozilla.org/mozilla-central/rev/00fcbf4c4aac

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.