Closed Bug 1546576 Opened 7 months ago Closed 7 months ago

Cancel vs kill workers during xpcom-shutdown

Categories

(Core :: DOM: Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently, RuntimeService kills all the active workers when xpcom-shutdown notification is received:

https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/dom/workers/RuntimeService.cpp#2174-2177
https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/dom/workers/RuntimeService.cpp#1643,1671

This means that, ChromeWorkers pass from Running state to Killing state directly.
What I suggest here is to cancel them during xpcom-shutdown in order to let them to terminate the operations and release IPDL actors correctly.

Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/451c85dbd572
Canceling workers during xpcom-shutdown, r=asuth
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.