Convert TestZip to a gtest

RESOLVED FIXED in Firefox 68

Status

()

task
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks 1 bug)

Trunk
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(3 attachments)

No description provided.

We're going to convert the test to a gtest, and it's simpler not to have
to deal with finding the path to the testcase zip files. They're small
enough anyways, and can be inserted as raw binary data via some assembly
magic. This being android-only code, we don't need extreme portability
here. This is the same trick we use in
config/external/icu/data/icudata_gas.S.

Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/28c357e15e37
Modernize loops in TestZip. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/a18a147e0dee
Include the TestZip zip files as binary data. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/40ea57b79736
Convert TestZip to a gtest. r=froydnj

This change has broken building for android with icecc for me. I get the following error:

4:18.62 <inline asm>:5:11: error: Could not find incbin file '/home/jamie/src/gecko/mozglue/linker/tests/test.zip'
4:18.62 .incbin "/home/jamie/src/gecko/mozglue/linker/tests/test.zip"
4:18.62 ^
4:18.62 <inline asm>:17:11: error: Could not find incbin file '/home/jamie/src/gecko/mozglue/linker/tests/no_central_dir.zip'
4:18.62 .incbin "/home/jamie/src/gecko/mozglue/linker/tests/no_central_dir.zip"
4:18.62 ^

Googling "incbin icecc" doesn't return much, but does find this qt change - https://codereview.qt-project.org/#/c/85416/ - which states that icecc and incbin are incompatible. Not sure whether that's strictly true or whether it just needs some work, this is well outside of my area of expertise.

Is there a mozconfig option or a line of code I can comment out to avoid invoking this?

Regressions: 1549762
You need to log in before you can comment on or make changes to this bug.