1546623 - Skia m74 might need to defined I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

On Solaris SPARC (big endian platform) I get with fix for Bug 1539026:

gmake[1]: Entering directory '/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/gfx/2d'
/usr/bin/g++ -o ConvolutionFilter.o -c -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/dist/stl_wrappers -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/dist/system_wrappers -include /builds/psumbera/FIREFOX/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_SOLARIS=1 -DUSE_CAIRO -DMOZ2D_HAS_MOZ_CAIRO -DMOZ_ENABLE_FREETYPE -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/psumbera/FIREFOX/gfx/2d -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/gfx/2d -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/ipc/ipdl/_ipdlheaders -I/builds/psumbera/FIREFOX/ipc/chromium/src -I/builds/psumbera/FIREFOX/ipc/glue -I/builds/psumbera/FIREFOX/gfx/skia -I/builds/psumbera/FIREFOX/gfx/skia/skia/include/config -I/builds/psumbera/FIREFOX/gfx/skia/skia/include/core -I/builds/psumbera/FIREFOX/gfx/skia/skia/include/docs -I/builds/psumbera/FIREFOX/gfx/skia/skia/include/gpu -I/builds/psumbera/FIREFOX/gfx/skia/skia/include/utils -I/builds/psumbera/FIREFOX/gfx/skia/skia/include/private -I/builds/psumbera/FIREFOX/gfx/skia/skia/src/core -I/builds/psumbera/FIREFOX/gfx/skia/skia/src/image -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/dist/include -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/dist/include/nspr -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++1z-compat -Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=coverage-mismatch -Wno-error=free-nonheap-object -Wformat -Wformat-overflow=2 -fno-sized-deallocation -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O -fno-omit-frame-pointer -funwind-tables -Wno-error=shadow -I/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/dist/include/cairo -I/usr/include/freetype2 -I/usr/include/libpng14 -I/usr/include/freetype2 -I/usr/include/libpng14 -MD -MP -MF .deps/ConvolutionFilter.o.pp /builds/psumbera/FIREFOX/gfx/2d/ConvolutionFilter.cpp
In file included from /builds/psumbera/FIREFOX/gfx/skia/skia/include/core/SkTypes.h:14:0,
from /builds/psumbera/FIREFOX/gfx/skia/skia/include/core/../private/../private/SkFloatBits.h:11,
from /builds/psumbera/FIREFOX/gfx/skia/skia/include/core/../private/SkFloatingPoint.h:11,
from /builds/psumbera/FIREFOX/gfx/skia/skia/include/core/SkScalar.h:11,
from /builds/psumbera/FIREFOX/gfx/skia/skia/include/private/SkFixed.h:12,
from /builds/psumbera/FIREFOX/gfx/skia/skia/src/core/SkBitmapFilter.h:11,
from /builds/psumbera/FIREFOX/gfx/2d/ConvolutionFilter.cpp:9:
/builds/psumbera/FIREFOX/gfx/skia/skia/include/core/SkPostConfig.h:44:6: error: #error "The Skia team is not endian-savvy enough to support big-endian CPUs."
#error "The Skia team is not endian-savvy enough to support big-endian CPUs."
^~~~~
/builds/psumbera/FIREFOX/gfx/skia/skia/include/core/SkPostConfig.h:45:6: error: #error "If you still want to use Skia,"
#error "If you still want to use Skia,"
^~~~~
/builds/psumbera/FIREFOX/gfx/skia/skia/include/core/SkPostConfig.h:46:6: error: #error "please define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN."
#error "please define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN."
^~~~~
gmake[1]: *** [/builds/psumbera/FIREFOX/config/rules.mk:807: ConvolutionFilter.o] Error 1
gmake[1]: Leaving directory '/builds/psumbera/FIREFOX/obj-sparc64-sun-solaris2.11/gfx/2d'

Comment 1

[Petr Sumbera]

Attachment: Bug 1546623 - Skia m74 might need defined I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1546623 - allow broken big-endian Skia builds

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/505d9ce41e46
allow broken big-endian Skia builds r=rhunt

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/505d9ce41e46