1546697 - Use consistent style for enum classes in layout.

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1546697 - EnumeratedArray should have a copy assignment operator. r=froydnj

I'll use this in a following patch.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1546697 - Make BaselineSharingGroup an enum class. r=mats

It looked a bit weird when mixed up with the other enum classes I'm about to
rename.

Depends on D28679

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1546697 - Use a consistent style for enum classes in layout. r=dholbert,mats

Per the discussion in:

https://groups.google.com/d/msg/mozilla.dev.platform/P79pwa9z5m8/iPYPAWPHCAAJ

They should be CamelCase, and that's what most of them already do. This converts
the rest, which are a few.

For the ones that already used e or k prefixes, I've mostly done:

for file in $(rg Type::e layout | cut -d : -f 1 | sort | uniq); do sed -i 's#Type::e#Type::#g' $file; done

For the ones that used uppercase, I've removed the prefix if it was already in
the type name, and turn them into CamelCase.

Depends on D28680

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1a3b366de8b
EnumeratedArray should have a copy assignment operator. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/15cb052119fe
Make BaselineSharingGroup an enum class. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/62da064b1b8f
Use a consistent style for enum classes in layout. r=dholbert

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/894d95f52dc2
followup: Fix a typo introduced in the last commit. r=a11y-orange

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b1a3b366de8b
https://hg.mozilla.org/mozilla-central/rev/15cb052119fe
https://hg.mozilla.org/mozilla-central/rev/62da064b1b8f
https://hg.mozilla.org/mozilla-central/rev/894d95f52dc2