Use consistent style for enum classes in layout.
Categories
(Core :: Layout, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(3 external files)
| Assignee | ||
Comment 1•7 years ago
|
||
I'll use this in a following patch.
| Assignee | ||
Comment 2•7 years ago
|
||
It looked a bit weird when mixed up with the other enum classes I'm about to
rename.
Depends on D28679
| Assignee | ||
Comment 3•7 years ago
|
||
Per the discussion in:
https://groups.google.com/d/msg/mozilla.dev.platform/P79pwa9z5m8/iPYPAWPHCAAJ
They should be CamelCase, and that's what most of them already do. This converts
the rest, which are a few.
For the ones that already used e or k prefixes, I've mostly done:
for file in $(rg Type::e layout | cut -d : -f 1 | sort | uniq); do sed -i 's#Type::e#Type::#g' $file; done
For the ones that used uppercase, I've removed the prefix if it was already in
the type name, and turn them into CamelCase.
Depends on D28680
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b1a3b366de8b
https://hg.mozilla.org/mozilla-central/rev/15cb052119fe
https://hg.mozilla.org/mozilla-central/rev/62da064b1b8f
https://hg.mozilla.org/mozilla-central/rev/894d95f52dc2
Description
•