Closed Bug 1546697 Opened 1 year ago Closed 1 year ago

Use consistent style for enum classes in layout.

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files)

No description provided.

It looked a bit weird when mixed up with the other enum classes I'm about to
rename.

Depends on D28679

Per the discussion in:

https://groups.google.com/d/msg/mozilla.dev.platform/P79pwa9z5m8/iPYPAWPHCAAJ

They should be CamelCase, and that's what most of them already do. This converts
the rest, which are a few.

For the ones that already used e or k prefixes, I've mostly done:

for file in $(rg Type::e layout | cut -d : -f 1 | sort | uniq); do sed -i 's#Type::e#Type::#g' $file; done

For the ones that used uppercase, I've removed the prefix if it was already in
the type name, and turn them into CamelCase.

Depends on D28680

Summary: Use consisting style for enum classes in layout. → Use consistent style for enum classes in layout.
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1a3b366de8b
EnumeratedArray should have a copy assignment operator. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/15cb052119fe
Make BaselineSharingGroup an enum class. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/62da064b1b8f
Use a consistent style for enum classes in layout. r=dholbert
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/894d95f52dc2
followup: Fix a typo introduced in the last commit. r=a11y-orange
You need to log in before you can comment on or make changes to this bug.