Closed Bug 1546714 Opened 6 months ago Closed 6 months ago

Map Remote Protocol :: {DOM, Input} bug components

Categories

(Remote Protocol :: Agent, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ato, Assigned: ato)

Details

Attachments

(2 files)

New Bugzilla components were introduced in
https://bugzilla.mozilla.org/show_bug.cgi?id=1543494, but we’re
missing rules to map them to the correct files in remote/moz.build.

Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1

There are two concepts of targets in CDP: the target web document,
and the Target domain. The remote/targets/ subfolder is related
to the first, which should have bugs filed under Remote Protocol ::
Agent, covered by the preceding rule.

DONTBUILD

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c29a7a2c36d6
remote: map Remote Protocol :: {DOM, Input} bug components; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/02a67f69acd2
remote: fix bug component mapping for remote/targets/; r=ochameau

Backed out 2 changesets (Bug 1546714) for test_mozbuild_reading.py bustages

Push with failures (was don't build) : https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=02a67f69acd2d0fe5023ae9aab8a5a35f779c466&selectedJob=242546760

Backout link: https://hg.mozilla.org/integration/autoland/rev/706b930d30b23e60f6faece80bd73c1c4006839f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=242546760&repo=autoland&lineNumber=39731

[task 2019-04-25T11:07:30.601Z] 11:07:30 INFO - /builds/worker/workspace/build/src/python/mozbuild/mozbuild/test/configure/test_moz_configure.py
[task 2019-04-25T11:07:30.601Z] 11:07:30 INFO - ============================= test session starts ==============================
[task 2019-04-25T11:07:30.601Z] 11:07:30 INFO - platform linux2 -- Python 2.7.9, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/obj-firefox-8yIyzR8r-2.7/bin/python
[task 2019-04-25T11:07:30.601Z] 11:07:30 INFO - rootdir: /builds/worker/workspace/build/src, inifile: /builds/worker/workspace/build/src/config/mozunit/mozunit/pytest.ini
[task 2019-04-25T11:07:30.601Z] 11:07:30 INFO - collecting ... collected 5 items
[task 2019-04-25T11:07:30.601Z] 11:07:30 INFO - ../python/mozbuild/mozbuild/test/configure/test_moz_configure.py::TestTargetLinux::test_target PASSED
[task 2019-04-25T11:07:30.601Z] 11:07:30 INFO - ../python/mozbuild/mozbuild/test/configure/test_moz_configure.py::TestTargetWindows::test_target PASSED
[task 2019-04-25T11:07:30.602Z] 11:07:30 INFO - ../python/mozbuild/mozbuild/test/configure/test_moz_configure.py::TestTargetAndroid::test_target PASSED
[task 2019-04-25T11:07:30.602Z] 11:07:30 INFO - ../python/mozbuild/mozbuild/test/configure/test_moz_configure.py::TestTargetOpenBSD::test_target PASSED
[task 2019-04-25T11:07:30.602Z] 11:07:30 INFO - ../python/mozbuild/mozbuild/test/configure/test_moz_configure.py::TestMozConfigure::test_nsis_version PASSED
[task 2019-04-25T11:07:30.602Z] 11:07:30 INFO - ========================== 5 passed in 20.66 seconds ===========================
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - /builds/worker/workspace/build/src/config/tests/test_mozbuild_reading.py
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - ============================= test session starts ==============================
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - platform linux2 -- Python 2.7.9, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/obj-firefox-8yIyzR8r-2.7/bin/python
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - rootdir: /builds/worker/workspace/build/src, inifile: /builds/worker/workspace/build/src/config/mozunit/mozunit/pytest.ini
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - collecting ... collected 3 items
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - ../config/tests/test_mozbuild_reading.py::TestMozbuildReading::test_filesystem_traversal_no_config PASSED
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - ../config/tests/test_mozbuild_reading.py::TestMozbuildReading::test_filesystem_traversal_reading <- ../../../../../usr/lib/python2.7/unittest/case.py SKIPPED
[task 2019-04-25T11:08:19.826Z] 11:08:19 WARNING - ../config/tests/test_mozbuild_reading.py::TestMozbuildReading::test_orphan_file_patterns TEST-UNEXPECTED-FAIL
[task 2019-04-25T11:08:19.826Z] 11:08:19 INFO - =================================== FAILURES ===================================
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - ________________ TestMozbuildReading.test_orphan_file_patterns _________________
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - self = <test_mozbuild_reading.TestMozbuildReading testMethod=test_orphan_file_patterns>
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - def test_orphan_file_patterns(self):
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - if sys.platform == 'win32':
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - raise unittest.SkipTest('failing on windows builds')
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - mb = MozbuildObject.from_environment(detect_virtualenv_mozinfo=False)
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - try:
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - config = mb.config_environment
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - except Exception as e:
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - if e.message == 'config.status not available. Run configure.':
[task 2019-04-25T11:08:19.827Z] 11:08:19 INFO - raise unittest.SkipTest('failing without config.status')
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - raise
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - if config.substs['MOZ_BUILD_APP'] == 'js':
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - raise unittest.SkipTest('failing in Spidermonkey builds')
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - reader = BuildReader(config)
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - all_paths = self._mozbuilds(reader)
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - _, contexts = reader.read_relevant_mozbuilds(all_paths)
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - finder = FileFinder(config.topsrcdir, ignore=['obj*'])
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - def pattern_exists(pat):
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - return [p for p in finder.find(pat)] != []
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - for ctx in contexts:
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - if not isinstance(ctx, Files):
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - continue
[task 2019-04-25T11:08:19.828Z] 11:08:19 INFO - relsrcdir = ctx.relsrcdir
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - for p in ctx.patterns:
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - if not pattern_exists(os.path.join(relsrcdir, p)):
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - self.fail("The pattern '%s' in a Files() entry in "
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - "'%s' corresponds to no files in the tree.\n"
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - "Please update this entry." %
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - > (p, ctx.main_path))
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - E AssertionError: The pattern 'domains/**/DOM.jsm' in a Files() entry in '/builds/worker/workspace/build/src/remote/moz.build' corresponds to no files in the tree.
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - E Please update this entry.
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - ../config/tests/test_mozbuild_reading.py:105: AssertionError
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - ================ 1 failed, 1 passed, 1 skipped in 71.74 seconds ================
[task 2019-04-25T11:08:19.829Z] 11:08:19 INFO - Setting retcode to 1 from /builds/worker/workspace/build/src/config/tests/test_mozbuild_reading.py
[task 2019-04-25T11:08:56.527Z] 11:08:56 INFO - /builds/worker/workspace/build/src/testing/xpcshell/selftest.py
[task 2019-04-25T11:08:56.528Z] 11:08:56 INFO - ============================= test session starts ==============================
[task 2019-04-25T11:08:56.528Z] 11:08:56 INFO - platform linux2 -- Python 2.7.9, pytest-3.6.2, py-1.5.4, pluggy-0.6.0 -- /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/obj-firefox-8yIyzR8r-2.7/bin/python
[task 2019-04-25T11:08:56.528Z] 11:08:56 INFO - rootdir: /builds/worker/workspace/build/src, inifile: /builds/worker/workspace/build/src/config/mozunit/mozunit/pytest.ini
[task 2019-04-25T11:08:56.528Z] 11:08:56 INFO - collecting ... collected 55 items
[task 2019-04-25T11:08:56.528Z] 11:08:56 INFO - ../testing/xpcshell/selftest.py::XPCShellTestsTests::testAddTaskRunNextTest PASSED

Flags: needinfo?(ato)

I will fix this by adding some stubs for these domains.

Flags: needinfo?(ato)
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc38b66e2356
remote: map Remote Protocol :: {DOM, Input} bug components; r=ochameau
https://hg.mozilla.org/integration/autoland/rev/635e8833ed5f
remote: fix bug component mapping for remote/targets/; r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.