Closed Bug 1546736 Opened 4 months ago Closed 3 months ago

Only capture stacks when net monitor is active

Categories

(DevTools :: Netmonitor, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhackett, Assigned: bhackett)

References

(Regressed 1 open bug)

Details

(Whiteboard: [debugger-mvp], leave-open)

Attachments

(4 files)

Bug 1392408 and bug 1392411 add C++ logic to capture stack traces when creating new workers or when workers make XHRs or web socket connections. These stacks are reported to the net monitor, but if the net monitor is not active they won't be used at all. It would be nice to only capture these stacks at times that the net monitor is active.

Priority: -- → P3
Blocks: 1392408
No longer depends on: 1392408

These patches are needed now to fix a treeherder failure that is preventing bug 1392408 from landing.

Assignee: nobody → bhackett1024
Status: NEW → ASSIGNED
Whiteboard: [debugger-mvp]
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d7e10772f55
Part 1 - Keep track of whether docshells and workers are being watched by the devtools, r=bzbarsky.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2f8435fe7ed
Part 2 - Set flag on docshell when devtools are watching it, r=ochameau.
https://hg.mozilla.org/integration/mozilla-inbound/rev/134b0641a7aa
Part 3 - Only capture worker script and XHR stacks for net monitor when devtools are watching the worker, r=bzbarsky.
Whiteboard: [debugger-mvp] → [debugger-mvp], leave-open
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c37ca68a24e5
Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky.
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72731b109310
Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky.
Regressions: 1552758
Regressions: 1552757
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.