1546736 - Only capture stacks when net monitor is active

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Brian Hackett [Laid off!]]

Bug 1392408 and bug 1392411 add C++ logic to capture stack traces when creating new workers or when workers make XHRs or web socket connections. These stacks are reported to the net monitor, but if the net monitor is not active they won't be used at all. It would be nice to only capture these stacks at times that the net monitor is active.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1546736 Part 1 - Keep track of whether docshells and workers are being watched by the devtools, r=bzbarsky.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1546736 Part 2 - Set flag on docshell when devtools are watching it, r=ochameau.

Depends on D30408

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Bug 1546736 Part 3 - Only capture worker script and XHR stacks for net monitor when devtools are watching the worker, r=bzbarsky.

Depends on D30410

Comment 4

[Brian Hackett [Laid off!]]

Attachment: Bug 1546736 Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky.

Depends on D30411

Comment 5

[Brian Hackett [Laid off!]]

These patches are needed now to fix a treeherder failure that is preventing bug 1392408 from landing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d7e10772f55
Part 1 - Keep track of whether docshells and workers are being watched by the devtools, r=bzbarsky.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2f8435fe7ed
Part 2 - Set flag on docshell when devtools are watching it, r=ochameau.
https://hg.mozilla.org/integration/mozilla-inbound/rev/134b0641a7aa
Part 3 - Only capture worker script and XHR stacks for net monitor when devtools are watching the worker, r=bzbarsky.

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4d7e10772f55
https://hg.mozilla.org/mozilla-central/rev/a2f8435fe7ed
https://hg.mozilla.org/mozilla-central/rev/134b0641a7aa

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c37ca68a24e5
Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72731b109310
Part 4 - Only capture web socket stacks for net monitor when the docshell/worker is being watched by the devtools, r=bzbarsky.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/72731b109310