tree and listbox shouldn't use search for keyboard navigation

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
16 years ago
10 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

({polish})

Trunk
x86
Windows 98
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
When a tree or listbox has focus some keys don't behave including these three:
Error: unterminated parenthetical (
Error: unterminated character class [
Error: trailing \ in regular expression
Error: invalid quantifier {
The errors appear on the JS console when the appropriate key is pressed.
These and other regexp characters don't work as expected.
(Assignee)

Comment 1

16 years ago
Created attachment 89446 [details] [diff] [review]
Proposed patch
(Assignee)

Updated

16 years ago
Keywords: patch, polish, review, ui

Comment 2

16 years ago
cc'ing kyle

Comment 3

16 years ago
-           else {
-             if (this._incrementalString.length != 1 || 
this._incrementalString.charAt(0) != key.charAt(0))
-               this._incrementalString += key;
-           }
+           else if (this._incrementalString != key)
+             this._incrementalString += key;

This fix has problem when user repeats pressing a same key, and it doesn't 
cause the JS exception.

Everything else is excellent! My original fix has low efficient and wrong 
string code. Good fix!
Assignee: hewitt → neil

Comment 4

16 years ago
Oh, forget my previous comment. I'm an idiot.

Comment 5

16 years ago
Comment on attachment 89446 [details] [diff] [review]
Proposed patch

r=kyle
Attachment #89446 - Flags: review+
(Assignee)

Updated

16 years ago
Attachment #89446 - Flags: superreview?(bzbarsky)

Comment 6

16 years ago
fixed by bug 192346! thanks for neil's fix!
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Comment on attachment 89446 [details] [diff] [review]
Proposed patch

removing obsolete review request. Did this patch no review before the checkin ?
Attachment #89446 - Flags: superreview?(bzbarsky)

Comment 8

16 years ago
Matti, this patch has been combined into the fix for bug 192346 that got
r=jkeiser and sr=henry.jia.

Updated

10 years ago
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.