Closed Bug 1546828 Opened 6 months ago Closed 5 months ago

Stub installer profile refresh check not properly getting current version number

Categories

(Firefox :: Installer, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 68
Tracking Status
firefox68 --- verified

People

(Reporter: mhowell, Assigned: mhowell)

Details

Attachments

(1 file)

The stub installer attempts to determine the latest version number on whatever channel it was built for in order to determine when to show its profile refresh prompt. It does this by querying the product-details.mozilla.org service. Currently that check appears to be always fail, due to a bug in the nsJSON plugin; the plugin only makes one call to InternetReadFile and assumes that call will retrieve the entire response body, instead of looping over InternetReadFile until it's actually returned all the data. We can fix this by using our InetBgDl plugin to execute that request instead.

The nsJSON plugin turns out not to handle waiting for an entire HTTP respoonse correctly,
so replace it with our InetBgDl plugin, which does.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mhowell, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mhowell)

Looks like I just forgot about this; since it's just a bug fix I'll go ahead and land it.

Flags: needinfo?(mhowell)
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87212d664f1f
Improve the stub installer's method for finding the most recent release. r=agashlin
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Hi, This issue is verified as fixed in Fx68 but please keep in mind the only test we could do was to verify that the stub installer will install Firefox latest version on both x86 and x64 versions of it.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.