Closed Bug 1546837 Opened 6 months ago Closed 5 months ago

Parameter names in mailTabs.setQuickFilter should match attribute names in messages.MessageHeader

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

MessageHeader uses "author" and "flagged", but setQuickFilter uses "sender" and "starred". We should use the same terminology in all places, so I want to deprecate "sender" and "starred" in favour of "author" and "flagged".

I'm not sure about read/unread, but that's probably okay.

Renames starred to flagged. I also added some more test coverage.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9063166 - Flags: review?(philipp)

Renames sender to author. This part of the code doesn't actually have any tests yet. One day.

Attachment #9063167 - Flags: review?(philipp)
Attachment #9063167 - Flags: review?(philipp) → review+
Attachment #9063166 - Flags: review?(philipp) → review+

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/df89486ce89c
Rename "starred" parameter to "flagged" in quick filter API method; r=Fallen
https://hg.mozilla.org/comm-central/rev/64a20f2677d9
Rename "sender" parameter to "author" in quick filter API method; r=Fallen

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 68.0
Blocks: 1581498
You need to log in before you can comment on or make changes to this bug.